Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Ghost Record Macro not working when multiple src_pk columns #232

Closed
ambullo opened this issue May 7, 2024 · 2 comments
Closed

[BUG] Ghost Record Macro not working when multiple src_pk columns #232

ambullo opened this issue May 7, 2024 · 2 comments

Comments

@ambullo
Copy link

ambullo commented May 7, 2024

We activated ghost records in our config but run into some issues.

We have multiple columns for the src_pk of our satellites. However, the macro for the ghost records does not accept multiple columns at this point. Therefore it will just ignore them and we run into a compilation error when we want to run the model.

The macro needs to be adjusted to accept multiple src_pk columns and handle them correctly. Point in the code where the issue occurs:

{%- if ((col_name | lower) == (src_pk | lower)) or ((col_name | lower) == (src_hashdiff | lower)) -%}

AB#5345

@DVAlexHiggs
Copy link
Member

Hi! Thank you for bringing this to our attention - it was an oversight on our part. We'll make sure a fix is including in our upcoming release. Thanks!

@DVAlexHiggs DVAlexHiggs changed the title Ghost Record Macro not working when multiple src_pk columns [BUG] Ghost Record Macro not working when multiple src_pk columns May 15, 2024
@DVAlexHiggs
Copy link
Member

DVAlexHiggs commented Jun 7, 2024

Fixed and released in v0.11.0, Thank you for your patience on this one!

If the issue persists, please re-open this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants