Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RabbitMqPortal needs to be revisited because it's not functional in the current state #3928

Open
StefanOssendorf opened this issue May 12, 2024 · 5 comments

Comments

@StefanOssendorf
Copy link
Contributor

The RabbitMqPortal implementation has two constructors.

public RabbitMqPortal(ApplicationContext applicationContext, IDataPortalServer dataPortal)

public RabbitMqPortal(string dataPortalUrl)

As you can see we can either set the necessary services or the data portal uri but NOT both. Hence I dare to say this implementation doesn't work as inteded.
So we should revisit this implementation to make it right.

Version and Platform
CSLA version: Current

@StefanOssendorf StefanOssendorf changed the title RabbitMqPortal needs to be revisited due to easy wrong usage RabbitMqPortal needs to be revisited because it's not functional in the current state May 12, 2024
@rockfordlhotka
Copy link
Member

Agreed. It should work with an options class like HttpProxy.

@rockfordlhotka
Copy link
Member

I wonder if GrpcPortal has the same issue?

@StefanOssendorf
Copy link
Contributor Author

I wonder if GrpcPortal has the same issue?

I don't think so. Or at least I did not create an issue during adding the nullable stuff :D

@Freelancingonupwork
Copy link
Contributor

Hello, i am not able to find any code related to this. May I know how I test it?

@rockfordlhotka
Copy link
Member

Hello, i am not able to find any code related to this. May I know how I test it?

It was originally something I created as a proof of concept, and so isn't well documented. I have now created a readme describing the way it should work.

The RabbitMqPortal type should really be getting its configuration from a RabbitMqPortalOptions instance (that type doesn't exist). And there should be a static RabbitMqPortalServerExtensions class that implements a UseRabbitMqPortal extension method that can be used on the host to configure the data portal host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants