Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Multiple hops to the same action in a workflow #3944

Closed
harrisward opened this issue May 16, 2024 · 2 comments · Fixed by #3947
Closed

[Bug]: Multiple hops to the same action in a workflow #3944

harrisward opened this issue May 16, 2024 · 2 comments · Fixed by #3947
Assignees
@nadment
Labels
bug Hop Gui P2 Default Priority Pipelines Workflows
Milestone
2.10

Comments

@harrisward
Copy link

Apache Hop version?

2.9.0-SNAPSHOT (2024-04-25 02.51.09)

Java version?

openjdk version "11.0.16.1" 2022-08-12 LTS

Operating system

Linux

What happened?

When you create a hop between two actions in a workflow its possible to duplicate a hop between two actions by splitting another hop. See the screensshots.

Do this.
image

Then this
image

Lastly split the original hop by dragging the time dimension action between the two actions above like this
image

Issue Priority

Priority: 2

Issue Component

Component: Workflows
@github-actions github-actions bot added P2 Default Priority Workflows labels May 16, 2024
@nadment
Copy link
Contributor

nadment commented May 16, 2024

Good catch, we just need to hardening the code to prevent this from happening

@nadment
Copy link
Contributor

nadment commented May 16, 2024

Pipelines have exactly the same problem

@nadment nadment self-assigned this May 16, 2024
nadment added a commit to nadment/hop that referenced this issue May 16, 2024
@nadment
Avoid multiple hops to the same destination apache#3944
d525eb7
nadment added a commit to nadment/hop that referenced this issue May 16, 2024
@nadment
Avoid multiple hops to the same destination apache#3944
c4479a6
@nadment nadment linked a pull request May 16, 2024 that will close this issue
Avoid multiple hops to the same destination #3944 #3947
Merged
nadment added a commit to nadment/hop that referenced this issue May 17, 2024
@nadment
Avoid multiple hops to the same destination apache#3944
35ee939 
Fix typo method name 'insetAction'
@nadment nadment added this to the 2.10 milestone May 21, 2024
hansva added a commit that referenced this issue May 27, 2024
@hansva
Merge pull request #3947 from nadment/3944
0df4d9a 
Avoid multiple hops to the same destination #3944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadment nadment

Labels
bug Hop Gui P2 Default Priority Pipelines Workflows
Projects
None yet
Milestone
2.10
Development

Successfully merging a pull request may close this issue.

Avoid multiple hops to the same destination #3944 nadment/hop
2 participants
@harrisward @nadment