Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not print password in error message on server startup #2020

Closed
yggdr opened this issue May 13, 2024 · 1 comment
Closed

Do not print password in error message on server startup #2020

yggdr opened this issue May 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@yggdr
Copy link

yggdr commented May 13, 2024

What did you expect to happen?

Some filtering on the configured db_uri to redact the configured password.

What happened?

When reinstalling atuin, due to some misconfiguration on my part, it printed this error message on startup:

Error: failed to connect to db: PostgresSettings { db_uri: "postgres://atuin:PASSWORD_HERE@10.0.9.105/atuin" }

Caused by:
[…]

which included the password.

Atuin doctor output

Atuin Doctor
Checking for diagnostics

[Filesystem] ZFS is known to have some issues with SQLite. Atuin uses SQLite heavily. If you are having poor performance, there are some workarounds here: https://github.com/atuinsh/atuin/issues/952

Please include the output below with any bug reports or issues

atuin:
  version: 18.2.0
  sync:
    cloud: false
    records: true
    auto_sync: true
    last_sync: 2024-05-13 12:28:42.386454986 +00:00:00
shell:
  name: 'python: xonsh'
  default: unknown
  plugins:
  - atuin
system:
  os: FreeBSD
  arch: amd64
  version: '14.0'
  disks:
[…]


### Code of Conduct

- [X] I agree to follow this project's Code of Conduct
@yggdr yggdr added the bug Something isn't working label May 13, 2024
@ellie
Copy link
Member

ellie commented May 21, 2024

Resolved by #2032

@ellie ellie closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants