Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support deferral of semantic models #10166

Open
3 tasks done
ChenyuLInx opened this issue May 17, 2024 · 4 comments
Open
3 tasks done

[Feature] Support deferral of semantic models #10166

ChenyuLInx opened this issue May 17, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@ChenyuLInx
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

We would want to generate the semantic manifest with deferral resolved to make sure the semantic model will point to the deferred node.
This would ensure a consistent experience of developing dbt & semantic model

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@ChenyuLInx ChenyuLInx added the enhancement New feature or request label May 17, 2024
@ChenyuLInx ChenyuLInx self-assigned this May 17, 2024
@ChenyuLInx
Copy link
Contributor Author

I think we need to update merge_from_artifact function to make sure semantic model's node relation gets updated?
Or should we include defer relation inside?
Sort of a tradeoff of whether dbt will resolve the deferral or metric flow.

@ChenyuLInx
Copy link
Contributor Author

We also could just include the deferal database /schema for each model inside the semantic manifest?

@jtcohen6
Copy link
Contributor

(tbt #8135!)

We also could just include the deferal database /schema for each model inside the semantic manifest?

a.k.a. the defer_relation! However, the defer_relation is added at runtime, not at parsing time. I had a proposal to change this, but I undid it because it needs a bit more consideration of potential downstream impact (e.g. partial parsing) before we implement: 6b63e31

@ChenyuLInx
Copy link
Contributor Author

I am thinking maybe during runtime we overwrite the original semantic manifest and add this. Need to think a bit more about how to better encapsulate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants