Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several leader key bindings in :lang gdscript no longer exist #7254

Closed
4 tasks done
bpseudopod opened this issue May 26, 2023 · 0 comments · Fixed by #7831
Closed
4 tasks done

Several leader key bindings in :lang gdscript no longer exist #7254

bpseudopod opened this issue May 26, 2023 · 0 comments · Fixed by #7831
Labels
is:update An effort to catch up with changes made elsewhere module:lang/gdscript Pertains to Doom's :lang gdscript module
Milestone
modules v24.06

Comments

@bpseudopod
Copy link
Contributor

bpseudopod commented May 26, 2023 •
edited by hlissner

I confirm that...

  • I have searched the issue tracker, documentation, FAQ, Discourse, and Google, in case this issue has already been reported/resolved.
  • I have read "How to Debug Issues", and will use it to provide as much information about this issue as possible.
  • The issue can be reproduced on the latest available commit of Doom.
  • The issue can be reproduced on a stable release of Emacs, such as 27 or 28. (Doom does not support development builds like 29+ or any version ending in .50 or .9x)

Expected behavior

In a gdscript-mode buffer, SPC m d a should create a breakpoint and SPC m d d should remove one.

Current behavior

The two bindings produce error messages:

Wrong type argument: commandp, gdscript-debug-add-breakpoint
Wrong type argument: commandp, gdscript-debug-remove-breakpoint

Respectively.
These functions do not exist in the gdscript-mode package, and have not since 2021. They were removed in this upstream commit. The successor to these functions, gdscript-debug-toggle-breakpoint, was introduced in the same commit (and bound to <f9> by default).

Recently, after a long dormant period, the upstream package has found new maintainers, who are currently working on updating it for the changes introduced in Godot 4.0. (There's eglot support now!) Quoting from a recent commit to the README:

"The debugger in this package is only for Godot 3. Godot 4 supports the Debugger Adapter Procol (DAP), which you can use with the dap-mode package."

So it might be time to rethink the keybindings for the debugger altogether. dap-mode upstream recently added support for Godot 4.

Steps to reproduce

  1. Open any file in gdscript-mode
  2. SPC m d d

System Information

https://pastebin.com/d9kzU0Up
@bpseudopod bpseudopod added is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet labels May 26, 2023
@bpseudopod bpseudopod mentioned this issue Apr 18, 2024
Merged
5 tasks
hlissner pushed a commit that referenced this issue Jun 3, 2024
@bpseudopod
fix(gdscript): replace removed functions with new binding
c625b78 
This commit removes the keybinds to add and remove a breakpoint in a
gdscript buffer, which were removed from gdscript-mode long ago, and
replaces them with one binding to toggle a breakpoint.

Fix: #7254
@hlissner hlissner added is:update An effort to catch up with changes made elsewhere module:lang/gdscript Pertains to Doom's :lang gdscript module and removed is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet labels Jun 3, 2024
@hlissner hlissner added this to the modules v24.06 milestone Jun 3, 2024
LemonBreezes pushed a commit to LemonBreezes/doomemacs that referenced this issue Jun 3, 2024
@bpseudopod @LemonBreezes
fix(gdscript): replace removed functions with new binding
b757a07 
This commit removes the keybinds to add and remove a breakpoint in a
gdscript buffer, which were removed from gdscript-mode long ago, and
replaces them with one binding to toggle a breakpoint.

Fix: doomemacs#7254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is:update An effort to catch up with changes made elsewhere module:lang/gdscript Pertains to Doom's :lang gdscript module
Projects
None yet
Milestone
modules v24.06
Development

Successfully merging a pull request may close this issue.

fix(gdscript): replace removed functions with new binding bpseudopod/doomemacs
2 participants
@hlissner @bpseudopod