-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plan to release etcd v3.5.14 #18013
Comments
Using links like v3.5.13...release-3.5 is nice, but please note that they are not static, they update as the branch is moved. In previous releases I listed each issues explicitly to make sure that we have concrete list that can inspected after the release. |
Thanks yeah they are mutable until tag is published, once tag is published we can compare actual immutable list of commits, i.e. v3.5.12...v3.5.13 I have link to draft changelog and also the header for proposed issues still needing backport which I will add to shortly:
|
Updated planning for this release below: Release team
Backports I have identified one required backport this morning and added to the list above. @ivanvc will also review and suggest any. @serathius are there any recent robustness related merges to Required backports will be discussed at triage tomorrow so we can invite the community to help get these completed in advance of the release date. Release date Discussed with @ivanvc today. We are both available 11:00 Pacific Time next Tuesday 28th or Wednesday 29th. @serathius would one of those options work for you for the call to cut the release? If so I will send the calendar invite. |
I did a sweep of issues and pull requests from the main branch since v3.5.13, and couldn't find any other possible candidates for being backported. |
@jmhbnz, @serathius, have we agreed on a date for the release? |
Please reach out to me on Slack to setup the meeting. |
etcd v3.5.14 is now public https://github.com/etcd-io/etcd/releases/tag/v3.5.14 Thanks to everyone who contributed to the release. I will leave this issue open for now as there are two release process improvement we would like to pursue following this release:
|
I'm currently testing this. |
I tried with
|
I don't have a way to test this. So, I don't want to raise the PR. But, from the documentation it seems like it should be possible to pass a path. Refer to: https://cloud.google.com/storage/docs/gsutil/commands/acl#set-options
And https://cloud.google.com/storage/docs/gsutil/commands/acl#ch-examples
|
So there are two instances where Line 246 in bf51a53
The above reference is ok as this is already limited to the specific etcd version being uploaded. Line 285 in bf51a53
This is the one causing log spam, as there are just over This Doing some more checking, one interesting thing is that the entire bucket seems to be already marked as fully public: I confirmed this with james ~
➜ gsutil iam get gs://artifacts.etcd-development.appspot.com --format=json \
| jq '.bindings[].members[]' | grep allUsers
"allUsers" Based on my findings above I believe there is no point running this command every release and we can just remove that problematic line from the release script without consequence. Or at very least gate it behind a check for We would need consensus from @ahrtr and @serathius on this. |
Thanks for driving the improvement!
Sounds good, but please manually verify it. e.g.
Also what if we transition from gcr.io to Artifact Registry? |
What would you like to be added?
What would you like to be added?
The etcd patch release criteria has been met for our
release-3.5
stable release branch so we should releasev3.5.14
.The list of commits included since the previous release is: v3.5.13...release-3.5
Work in progress CHANGELOG is: https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.5.md#v3514-tbd
List of pull requests we still need to backport from
main
torelease-3.5
before the patch release is issued:Why is this needed?
Regular patch releases are vital to ensure our users have bug free and secure software.
The text was updated successfully, but these errors were encountered: