-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flutter 3.22.0 Drawer is flickering when opening/closing #148607
Comments
Thank you for the report. I can reproduce this on Linux app as well. The issue doesn't occur on Web or macOS app target. I noticed the issue doesn't happen if I remove Sample code with AnimatedContainerdrawer: Drawer(
child: SingleChildScrollView(
child: Column(
children: [
AnimatedContainer(
duration: const Duration(seconds: 1),
curve: Curves.fastOutSlowIn,
padding: const EdgeInsets.all(16),
decoration: const BoxDecoration(
color: Colors.blue,
),
child: const UserAccountsDrawerHeader(
accountName: Text("User"),
accountEmail: Text("user@mail.com"),
),
),
...List.generate(
10,
(index) => ListTile(
title: Text('Item $index'),
onTap: () {
Navigator.pop(context);
},
),
),
],
),
),
), flutter doctor -v (stable & master)[✓] Flutter (Channel stable, 3.22.0, on Ubuntu 22.04.3 LTS 6.5.0-26-generic, locale en_US.UTF-8)
• Flutter version 3.22.0 on channel stable at /home/huynq/Documents/Working/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 5dcb86f68f (11 days ago), 2024-05-09 07:39:20 -0500
• Engine revision f6344b75dc
• Dart version 3.4.0
• DevTools version 2.34.3
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0-rc3)
• Android SDK at /home/huynq/Android/Sdk/
• Platform android-33, build-tools 34.0.0-rc3
• Java binary at: /snap/android-studio/current/jbr/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
• All Android licenses accepted.
[✓] Chrome - develop for the web
• Chrome at google-chrome
[✓] Linux toolchain - develop for Linux desktop
• Ubuntu clang version 14.0.0-1ubuntu1.1
• cmake version 3.22.1
• ninja version 1.10.1
• pkg-config version 0.29.2
[✓] Android Studio (version 2021.1)
• Android Studio at /home/huynq/Documents/android-studio
• Flutter plugin version 67.0.1
• Dart plugin version 211.7817
• Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)
[!] Android Studio (version unknown)
• Android Studio at /snap/android-studio/current
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
✗ Unable to determine Android Studio version.
• android-studio-dir = /snap/android-studio/current
• Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
[✓] VS Code (version 1.84.2)
• VS Code at /usr/share/code
• Flutter extension version 3.86.0
[✓] VS Code (version 1.88.1)
• VS Code at /snap/code/current/usr/share/code
• Flutter extension version 3.86.0
[✓] Connected device (2 available)
• Linux (desktop) • linux • linux-x64 • Ubuntu 22.04.3 LTS 6.5.0-26-generic
• Chrome (web) • chrome • web-javascript • Google Chrome 120.0.6099.199
[✓] Network resources
• All expected network resources are available.
! Doctor found issues in 1 category. [!] Flutter (Channel master, 3.22.0-36.0.pre.54, on Ubuntu 22.04.3 LTS 6.5.0-26-generic, locale en_US.UTF-8)
• Flutter version 3.22.0-36.0.pre.54 on channel master at /home/huynq/Documents/Working/flutter_master
! Warning: `flutter` on your path resolves to /home/huynq/Documents/Working/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /home/huynq/Documents/Working/flutter_master. Consider adding /home/huynq/Documents/Working/flutter_master/bin to the front of your path.
! Warning: `dart` on your path resolves to /home/huynq/Documents/Working/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /home/huynq/Documents/Working/flutter_master. Consider adding /home/huynq/Documents/Working/flutter_master/bin to the front of your path.
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 414d923872 (3 hours ago), 2024-05-19 21:58:34 -0400
• Engine revision c6fecf65fb
• Dart version 3.5.0 (build 3.5.0-169.0.dev)
• DevTools version 2.36.0-dev.10
• If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0-rc3)
• Android SDK at /home/huynq/Android/Sdk/
• Platform android-33, build-tools 34.0.0-rc3
• Java binary at: /snap/android-studio/current/jbr/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
• All Android licenses accepted.
[✓] Chrome - develop for the web
• Chrome at google-chrome
[✓] Linux toolchain - develop for Linux desktop
• Ubuntu clang version 14.0.0-1ubuntu1.1
• cmake version 3.22.1
• ninja version 1.10.1
• pkg-config version 0.29.2
[✓] Android Studio (version 2021.1)
• Android Studio at /home/huynq/Documents/android-studio
• Flutter plugin version 67.0.1
• Dart plugin version 211.7817
• Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)
[!] Android Studio (version unknown)
• Android Studio at /snap/android-studio/current
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
✗ Unable to determine Android Studio version.
• android-studio-dir = /snap/android-studio/current
• Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
[✓] VS Code (version 1.84.2)
• VS Code at /usr/share/code
• Flutter extension version 3.88.0
[✓] VS Code (version 1.88.1)
• VS Code at /snap/code/current/usr/share/code
• Flutter extension version 3.88.0
[✓] Connected device (2 available)
• Linux (desktop) • linux • linux-x64 • Ubuntu 22.04.3 LTS 6.5.0-26-generic
• Chrome (web) • chrome • web-javascript • Google Chrome 120.0.6099.199
[✓] Network resources
• All expected network resources are available.
! Doctor found issues in 2 categories. |
I bisected this to 8e418d1. Perhaps it is flutter/engine#50754? git bisect (tailed output)8e418d18185697e56024ef3d5784afba4ac96370 is the first bad commit
commit 8e418d18185697e56024ef3d5784afba4ac96370
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date: Thu Feb 29 19:05:57 2024 -0500
Roll Flutter Engine from 7e8fefe4a084 to 6f8044436eb3 (5 revisions) (#144436)
https://github.com/flutter/engine/compare/7e8fefe4a084...6f8044436eb3
2024-02-29 jonahwilliams@google.com [Impeller] use specific format for bootstrap texture. (flutter/engine#51082)
2024-02-29 jonahwilliams@google.com [Impeller] remove warning about device transient depth+stencil. (flutter/engine#51033)
2024-02-29 robert.ancell@canonical.com Refactor GL rendering to prepare for GTK4 (flutter/engine#50754)
2024-02-29 jacksongardner@google.com Reland "[skwasm] Clip pictures if they go beyond the bounds of the window." (flutter/engine#51077)
2024-02-29 matej.knopp@gmail.com Revert "[macOS] Use CVDisplayLink to drive repaint (#49159)" (flutter/engine#51095)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bin/internal/engine.version | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
|
Thank you for bisecting this regression @huycozy! Relabelled to the engine team to see what they think. |
Probably the same as #148653 which I am currently investigating. |
Confirmed this issue is the same as #148653 and fixed in flutter/engine#53103 |
Thank you for fixing this! |
Issue still not fixed. Tried with Flutter 3.22.2 |
@Dan-ru CP request flutter/engine#53183 has not merged yet so this is not available on hotfix release. But you can try it on master channel. |
Steps to reproduce
Just run sample code in debug or release mode, then open/close drawer.
But it will work correctly in debug mode if debugShowCheckedModeBanner is set to "true".
With Flutter 3.19.6 it works correctly.
Expected results
Normal work without artifacts and flickering
Actual results
Artifacts and flickering while opening/closing drawer.
Code sample
Code sample
Screenshots or Video
Screenshots / Video demonstration
20240518_151746.webm
Logs
Logs
Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):The text was updated successfully, but these errors were encountered: