Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] include shared libs in sycl release #7361

Closed
gfody opened this issue May 18, 2024 · 3 comments
Closed

[SYCL] include shared libs in sycl release #7361

gfody opened this issue May 18, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@gfody
Copy link

gfody commented May 18, 2024

can the shared libs be included in the bin-win-sycl-x64 release?
@gfody gfody added the enhancement New feature or request label May 18, 2024
@gfody gfody changed the title include shared libs in sycl release [SYCL] include shared libs in sycl release May 18, 2024
@gfody gfody mentioned this issue May 21, 2024
Open
@NeoZhangJianyu
Copy link
Collaborator

@gfody
Yes, it's supported by PR #7241.

@gfody
Copy link
Author

gfody commented May 21, 2024

ah yeah the sycl dependencies are included but llama.dll is missing, because -DBUILD_SHARED_LIBS=ON is not here:

llama.cpp/examples/sycl/win-build-sycl.bat

Line 19 in 917dc8c

cmake -G "MinGW Makefiles" .. -DLLAMA_SYCL=ON -DCMAKE_C_COMPILER=icx -DCMAKE_CXX_COMPILER=icx -DCMAKE_BUILD_TYPE=Release

@NeoZhangJianyu
Copy link
Collaborator

Yes, we will check and fix it.

@gfody gfody mentioned this issue May 22, 2024
Merged
@gfody gfody closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gfody @NeoZhangJianyu