Writes are interrupted when suspending

[PotatoesFall]

Summary

First of all thank you to everybody who has been working on this fantastic editor ❤️

When I save a file in the editor (usually using Space-W), and then immediately suspend (using C-z), the file is sometimes not written. Only when I then use fg to resume helix, is the file saved.

Since suspending is a big part of my workflow, this has messed me up countless times because my recent changes weren't working (because they weren't saved)

It would be awesome if any save actions are still executed even if helix is suspended. Is that possible?

Reproduction Steps

I tried this:

1. hx {file}
2. make changed
3. :w
4. C-z
5. check if file was saved

I expected this to happen:

File was saved with new changes

Instead, this happened:

File was not saved

Helix log

~/.cache/helix/helix.log

2024-05-15T17:38:32.021 helix_core::syntax [ERROR] TS parser failed, disabling TS for the current buffer: Err(Cancelled)

Platform

Fedora Linux 39

Terminal Emulator

alacritty 0.13.2

Installation Method

source

Helix Version

helix 24.3 (2cadec0)

[the-mikedavis]

C-z (the suspend command) raises SIGTSTP and stops the process so I don't believe we can continue to write in the background. We could block on any writes before raising the signal though, like how we block on writes in :quit

[PotatoesFall]

I think that would be a huge improvement!

One thing to add, I'm pretty sure this is only happening for my .go files. On save there is autoformatting (gofmt/goimports) happening, causing a small delay. I was not able to replicate this with a simple text file. I assume that the time taken for autoformatting is long enough for this to happen reliably, while for normal saves it's not a problem.

I think a lot of people are using autoformat on save, and go has a fairly fast toolchain for that. I imagine I'm not the only one with this problem, although I haven't been able to find any other reports of this issue.

[lpoirothattermann]

@PotatoesFall can you try my commit, let me know if it's working as expected.

[PotatoesFall]

Hey @lpoirothattermann thanks so much for taking the time to help out!

I feel it's rude to just make another MR while yours is active but I saw there was some criticism on your MR and I had some time today and wanted to take a stab at this myself. Apologies.

[lpoirothattermann]

Hey @lpoirothattermann thanks so much for taking the time to help out!

I feel it's rude to just make another MR while yours is active but I saw there was some criticism on your MR and I had some time today and wanted to take a stab at this myself. Apologies.

No problem :)