Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRONTEND: Random Products Flutter App #79

Open
MananGandhi1810 opened this issue Feb 6, 2024 · 17 comments · May be fixed by #103
Open

FRONTEND: Random Products Flutter App #79

MananGandhi1810 opened this issue Feb 6, 2024 · 17 comments · May be fixed by #103
Assignees
Labels
enhancement New feature or request frontend Related to frontend contribution

Comments

@MananGandhi1810
Copy link

Frontend App Title

Random Products Flutter App

Overview

The Random Products App will be built using flutter, and will allow users to browse the different products.

Detailed Features

  1. Home Page - The home page will consist of random products from the API, along with their brand name and a thumbnail.
  2. Product Details Page - The product details page will show the product in detail, along with carousel slider for viewing the images, along with its price, rating and an indicator if the stock of the product is close to ending.
  3. Search Page - the search bar will allow the users to search for a product, and they will be able to see results for their queries.

Tech Stack Used

Flutter, Provider

Built For Platform

mobile

Project Path

$ROOT_FOLDER/examples/public/randomproducts/mobile/flutter-provider

@MananGandhi1810 MananGandhi1810 added enhancement New feature or request frontend Related to frontend contribution labels Feb 6, 2024
@wajeshubham
Copy link
Collaborator

Hi @MananGandhi1810,

Thank you for your contribution proposal 🚀! Your idea for the Random Products Flutter App sounds exciting and promising😀. Please go ahead and proceed with implementing the features outlined in your proposal 👍🏼.

As you work on the project, I want to emphasize the importance of adhering to good coding practices. This includes writing clean, readable code, following consistent naming conventions, and ensuring proper documentation. Remember, clear and well-organized code not only makes it easier for others to understand and collaborate but also contributes to the long-term maintainability of the project.

Additionally, I'd like to kindly remind you to update the README.md file in your project comprehensively. This README serves as a crucial guide for other developers who may want to understand the purpose of the project, how to set it up, and how to contribute.

Before you begin, please make sure to read our frontend contribution and contribution guide to get an idea about the instructions and expectations for contributions. Once you start and commit your first changes, please create a PR (Pull Request). This will allow us to provide feedback and ensure that your contributions align with the project's goals and standards.

Feel free to reach out if you have any questions or need further assistance along the way. Looking forward to seeing your progress on the Random Products Flutter App!

Best regards,
FreeAPI team

@Sarthak-ONS
Copy link
Contributor

Hi @wajeshubham

I'm eager to contribute to the development of the specified feature. Could you please grant me permission to work on this feature?

Looking forward to your response.

@MananGandhi1810
Copy link
Author

@Sarthak-ONS I'm ready to work collaboratively on this feature with you, if the maintainer @wajeshubham agrees to let us do so

@Sarthak-ONS
Copy link
Contributor

@Sarthak-ONS I'm ready to work collaboratively on this feature with you, if the maintainer @wajeshubham agrees to let us do so

Happy to work with you!

@Sarthak-ONS
Copy link
Contributor

@Sarthak-ONS I'm ready to work collaboratively on this feature with you, if the maintainer @wajeshubham agrees to let us do so

Happy to work with you!

@wajeshubham Awaiting your response on this!

@wajeshubham
Copy link
Collaborator

@Sarthak-ONS @MananGandhi1810 Yes, please go ahead.

@MananGandhi1810
Copy link
Author

@Sarthak-ONS I'll add you as a collaborator to my forked repo, and then we can decide how to go about the project

@Sarthak-ONS
Copy link
Contributor

@Sarthak-ONS I'll add you as a collaborator to my forked repo, and then we can decide how to go about the project

Hi @MananGandhi1810, Sure we can discuss how we will approach this project and go further.

@MananGandhi1810
Copy link
Author

Please let me know how you would like to go about it

@MananGandhi1810
Copy link
Author

I am extremely sorry, but is it possible that I be unassigned from the issue. I do not have enough to time to continue with this. @Sarthak-ONS can continue with this.

Again extremely sorry for this 😥😥

@Sarthak-ONS
Copy link
Contributor

Hi @MananGandhi1810, no issues I will work on it.

Hi @wajeshubham, please assign this issue to me. Thanks

@Sarthak-ONS Sarthak-ONS linked a pull request Mar 14, 2024 that will close this issue
@Sarthak-ONS
Copy link
Contributor

Hi @wajeshubham @jwala-anirudh , Is there any endpoint for searching products? If not, then what should I do for that?

@Sarthak-ONS
Copy link
Contributor

Hi, @wajeshubham @jwala-anirudh , I am waiting for your responses.

@wajeshubham
Copy link
Collaborator

wajeshubham commented Mar 18, 2024

@Sarthak-ONS get all random products api itself has a search query parameter which is responsible for the searching.

Checkout this code line: https://github.com/hiteshchoudhary/apihub/blob/main/src%2Fcontrollers%2Fpublic%2Frandomproduct.controllers.js#L10

Also here's the swagger api item in which, if you lass anything in query key it will give you products matching that search query

@Sarthak-ONS
Copy link
Contributor

image

The API response shown in the uploaded image does not align with the standard structure expected from the product and product by ID endpoints as defined in the product.controllers.js file. The product ID is not a valid Mongoose ID, and the image structure is also different. This discrepancy raises concerns about how users would be able to click on a product and view its full details.

@Sarthak-ONS
Copy link
Contributor

@wajeshubham & @jwala-anirudh awaiting your response on this.

@wajeshubham
Copy link
Collaborator

@Sarthak-ONS The public APIs don't interact with the database, so I'm not entirely sure why the ID not being an ObjectId is an issue. You can use the numeric ID provided to fetch the product by id by calling the public random product get product by id api itself and not the e-com product api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Related to frontend contribution
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants