Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stories with same name overwrite each others screenshot #206

Open
chriskalmar opened this issue Sep 30, 2022 · 1 comment
Open

Stories with same name overwrite each others screenshot #206

chriskalmar opened this issue Sep 30, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@chriskalmar
Copy link
Collaborator

Bug description

Using the same name for 2 or more stories leads to having the same filename.

This function needs to be refactored:
https://github.com/lost-pixel/lost-pixel/blob/main/src/crawler/storybook.ts#L244-L245

How to reproduce

Run Lost Pixel in storybook mode with at least 2 stories with the same name.

Expected behavior

No response

Lost Pixel information

lost-pixel logs from CI

No response

@chriskalmar chriskalmar added the bug Something isn't working label Sep 30, 2022
@d-ivashchuk d-ivashchuk added the good first issue Good for newcomers label Oct 1, 2022
@joaogarin
Copy link

joaogarin commented Jun 8, 2024

Hello, curious what is the use case here? I am looking into the codebase and found this issue but not sure what would be a way to trigger this..

Run Lost Pixel in storybook mode with at least 2 stories with the same name.

If the file name is different the filename generated by lost pixel will also be different right? In the case that the story has the same name it looks like its already cut off in stories.json?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants