Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show codec flavor in stats also in passthrough mode #14178

Closed
mitzsch opened this issue May 19, 2024 · 1 comment · Fixed by #14188
Closed

Show codec flavor in stats also in passthrough mode #14178

mitzsch opened this issue May 19, 2024 · 1 comment · Fixed by #14188
Labels
meta:feature-request

Comments

@mitzsch
Copy link
Contributor

mitzsch commented May 19, 2024

Expected behavior of the wanted feature

With the newest mpv it shows the codec flavor in the stats, as seen here =>

image

With passthrough enabled it only shows something like this =>

current_state

It would be awesome if instead of [spdif_dts_hd] it would also show the codec with flavor like seen above. => e.g. for TrueHD/Atmos passthrough => TrueHD [TrueHD + Atmos] or spdif_truehd [TrueHD + Atmos] or libavformat/spdifenc audio pass-through decoder [TrueHD + Atmos]

Thanks!

Alternative behavior of the wanted feature

No response

Log File

No response

Sample Files

No response
@kasper93
Copy link
Contributor

kasper93 commented May 19, 2024 •
edited

codec profile is not accessible, this information is given by the decoder after the actual data is decoded. In passthrough mode we only have codec. I've added missing description, which should fix empty field in stats #14179

kasper93 added a commit to kasper93/mpv that referenced this issue May 20, 2024
@kasper93
ad_spdif: set codec params
b97c435 
It seems that we decode small portion of the audio to determine codec
params. We can remember that information.

Fixes: mpv-player#14178
@kasper93 kasper93 mentioned this issue May 20, 2024
Merged
kasper93 added a commit to kasper93/mpv that referenced this issue May 20, 2024
@kasper93
ad_spdif: set codec params
bba2b9b 
It seems that we decode small portion of the audio to determine codec
params. We can remember that information.

Fixes: mpv-player#14178
kasper93 added a commit to kasper93/mpv that referenced this issue May 20, 2024
@kasper93
ad_spdif: set codec params
a72f8f6 
It seems that we decode small portion of the audio to determine codec
params. We can remember that information.

Fixes: mpv-player#14178
kasper93 added a commit to kasper93/mpv that referenced this issue May 20, 2024
@kasper93
ad_spdif: set codec params
db9d819 
It seems that we decode small portion of the audio to determine codec
params. We can remember that information.

Fixes: mpv-player#14178
kasper93 added a commit that referenced this issue May 22, 2024
@kasper93
ad_spdif: set codec params
6eb0f4b 
It seems that we decode small portion of the audio to determine codec
params. We can remember that information.

Fixes: #14178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta:feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ad_spdif: set codec params kasper93/mpv
2 participants
@kasper93 @mitzsch