Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funscript heatmap generation incorrectly processes duration metatag #1733

Open
Mellified opened this issue May 18, 2024 · 1 comment
Open

Comments

@Mellified
Copy link

Funscripts can optionally include a metadata tag "duration". When xbvr generates a heatmap it assumes the value is in seconds. However, the convention is to use the same units as the rest of the funscript - milliseconds. This results in the generated heatmap having all the action squished to the left/beginning, since the duration is 1000x longer than it should be.

@Mellified
Copy link
Author

Mellified commented May 18, 2024

OpenFunscripter apparently uses seconds for duration, but both Funscript.io and FunscriptToolbox use milliseconds. xbvr could ignore the duration completely. This means funscripts which have actions for only part of the video may not have correct heatmaps however. So the ideal solution may be a ruleset to decide when to use the duration tag as seconds, milliseconds, or to ignore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant