Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database as resource #164

Open
Ughuuu opened this issue Feb 22, 2024 · 3 comments · May be fixed by #165
Open

Database as resource #164

Ughuuu opened this issue Feb 22, 2024 · 3 comments · May be fixed by #165
Labels
enhancement New feature or request

Comments

@Ughuuu
Copy link

Ughuuu commented Feb 22, 2024

Is your feature request related to a problem? Please describe.

Would be cool to be able to see databases(.sqlite files) in godot files inspector.

Describe the solution you'd like

A resource loader for sqlite that only loads the filename in memory(not the whole db) and a resource for sqlite.

Eg:

Resource and Resource Loader.

https://github.com/V-Sekai/godot-whisper/blob/main/src/resource_whisper.h
https://github.com/V-Sekai/godot-whisper/blob/main/src/resource_whisper.cpp
https://github.com/V-Sekai/godot-whisper/blob/main/src/resource_loader_whisper.h
https://github.com/V-Sekai/godot-whisper/blob/main/src/resource_loader_whisper.cpp

Describe alternatives you've considered

Additional context

@Ughuuu Ughuuu added the enhancement New feature or request label Feb 22, 2024
@Ughuuu
Copy link
Author

Ughuuu commented Feb 23, 2024

I'll implement it and you can merge it if you want.

@Ughuuu Ughuuu linked a pull request Feb 23, 2024 that will close this issue
@2shady4u
Copy link
Owner

2shady4u commented Mar 4, 2024

@Ughuuu
I see you made a PR draft for this feature.
Are you planning to still work on this PR or is it feature-complete and just awaiting my feedback?

@Ughuuu
Copy link
Author

Ughuuu commented Mar 4, 2024

Hi, also got distracted, first wanted to see your reaction. I need to retest it but the idea is there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants