Pull and resnapshot disappeared from the menu? #1306

gerroon · 2024-01-03T17:32:30Z

gerroon
Jan 3, 2024

We used to have additional options when selecting an existing snapshot. Those options seem to be gone, they were on the line where "Tags" is now. The "Tags" element also does not seem to be doing anything functionally.

0.7.1
ArchiveBox v0.7.1+editable BUILD_TIME=2024-01-03 04:00:11 1704254411
IN_DOCKER=True IN_QEMU=False ARCH=x86_64 OS=Linux PLATFORM=Linux-5.14.0-4-amd64-x86_64-with-glibc2.36 PYTHON=Cpython
FS_ATOMIC=True FS_REMOTE=True FS_USER=1000:1000 FS_PERMS=644
DEBUG=False IS_TTY=True TZ=UTC SEARCH_BACKEND=sonic LDAP=False

[i] Dependency versions:
 √  PYTHON_BINARY         v3.11.7         valid     /usr/local/bin/python3.11
 √  SQLITE_BINARY         v2.6.0          valid     /usr/local/lib/python3.11/sqlite3/dbapi2.py
 √  DJANGO_BINARY         v3.1.14         valid     /usr/local/lib/python3.11/site-packages/django/__init__.py
 √  ARCHIVEBOX_BINARY     v0.7.1          valid     /usr/local/bin/archivebox

 √  CURL_BINARY           v8.4.0          valid     /usr/bin/curl
 √  WGET_BINARY           v1.21.3         valid     /usr/bin/wget
 √  NODE_BINARY           v20.10.0        valid     /usr/bin/node
 √  SINGLEFILE_BINARY     v1.1.46         valid     /app/node_modules/single-file-cli/single-file
 √  READABILITY_BINARY    v0.0.11         valid     /app/node_modules/readability-extractor/readability-extractor
 √  MERCURY_BINARY        v1.0.0          valid     /app/node_modules/@postlight/parser/cli.js
 √  GIT_BINARY            v2.39.2         valid     /usr/bin/git
 √  YOUTUBEDL_BINARY      v2023.12.30     valid     /usr/local/bin/yt-dlp
 √  CHROME_BINARY         v120.0.6099.28  valid     /usr/bin/chromium-browser
 √  RIPGREP_BINARY        v13.0.0         valid     /usr/bin/rg

[i] Source-code locations:
 √  PACKAGE_DIR           23 files        valid     /app/archivebox
 √  TEMPLATES_DIR         3 files         valid     /app/archivebox/templates
 -  CUSTOM_TEMPLATES_DIR  -               disabled  None

[i] Secrets locations:
 -  CHROME_USER_DATA_DIR  -               disabled  None
 -  COOKIES_FILE          -               disabled  None

[i] Data locations:
 √  OUTPUT_DIR            13 files @      valid     /data
 √  SOURCES_DIR           188 files       valid     ./sources
 √  LOGS_DIR              1 files         valid     ./logs
 √  ARCHIVE_DIR           119 files       valid     ./archive
 √  CONFIG_FILE           554.0 Bytes     valid     ./ArchiveBox.conf
 √  SQL_INDEX             1.7 MB          valid     ./index.sqlite3

Answered by pirate

Jan 4, 2024

thanks for reporting! this was caused by a recent change (#1274) to show an upgrade hint banner that added extra_context to the admin views, but apparently not all the built-in Django views can accept that extra parameter. I have reverted it for now (4af9bee) and a new 0.7 build with the fix should be up within ~20min on Docker Hub.

fyi @benmuth can you figure out a different way to pass the global context to only the admin views that need it?

View full answer

jack555444 · 2024-01-03T20:39:44Z

jack555444
Jan 3, 2024

I have the exact same issue. All the options have disappeared. I'm running the latest build on Docker using the dev tag.

In addition if I try and add a tag to an existing snapshot the UI states "The results could not be loaded."

I note the following in the log:

2024-01-03T16:57:39.348026038Z Internal Server Error: /admin/core/tag/autocomplete/
2024-01-03T16:57:39.348038691Z Traceback (most recent call last):
2024-01-03T16:57:39.348061060Z   File "/usr/local/lib/python3.11/site-packages/django/core/handlers/exception.py", line 47, in inner
2024-01-03T16:57:39.348062878Z     response = get_response(request)
2024-01-03T16:57:39.348064205Z                ^^^^^^^^^^^^^^^^^^^^^
2024-01-03T16:57:39.348065499Z   File "/usr/local/lib/python3.11/site-packages/django/core/handlers/base.py", line 181, in _get_response
2024-01-03T16:57:39.348066983Z     response = wrapped_callback(request, *callback_args, **callback_kwargs)
2024-01-03T16:57:39.348068326Z                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-01-03T16:57:39.348069680Z   File "/usr/local/lib/python3.11/site-packages/django/contrib/admin/options.py", line 614, in wrapper
2024-01-03T16:57:39.348071068Z     return self.admin_site.admin_view(view)(*args, **kwargs)
2024-01-03T16:57:39.348072413Z            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-01-03T16:57:39.348073740Z   File "/usr/local/lib/python3.11/site-packages/django/utils/decorators.py", line 130, in _wrapped_view
2024-01-03T16:57:39.348075157Z     response = view_func(request, *args, **kwargs)
2024-01-03T16:57:39.348076434Z                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-01-03T16:57:39.348077735Z   File "/usr/local/lib/python3.11/site-packages/django/views/decorators/cache.py", line 44, in _wrapped_view_func
2024-01-03T16:57:39.348079137Z     response = view_func(request, *args, **kwargs)
2024-01-03T16:57:39.348080433Z                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-01-03T16:57:39.348081700Z   File "/usr/local/lib/python3.11/site-packages/django/contrib/admin/sites.py", line 233, in inner
2024-01-03T16:57:39.348083113Z     return view(request, *args, **kwargs)
2024-01-03T16:57:39.348084383Z            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-01-03T16:57:39.348085683Z TypeError: ModelAdmin.autocomplete_view() got an unexpected keyword argument 'extra_context'

0 replies

pirate · 2024-01-04T00:12:57Z

pirate
Jan 4, 2024
Maintainer

thanks for reporting! this was caused by a recent change (#1274) to show an upgrade hint banner that added extra_context to the admin views, but apparently not all the built-in Django views can accept that extra parameter. I have reverted it for now (4af9bee) and a new 0.7 build with the fix should be up within ~20min on Docker Hub.

fyi @benmuth can you figure out a different way to pass the global context to only the admin views that need it?

4 replies

gerroon Jan 4, 2024
Author

Thanks for the update, however sadly that did not seem to fix it?

ArchiveBox v0.7.1+editable BUILD_TIME=2024-01-04 00:28:37 1704328117
IN_DOCKER=True IN_QEMU=False ARCH=x86_64 OS=Linux PLATFORM=Linux-5.14.0-4-amd64-x86_64-with-glibc2.36 PYTHON=Cpython
FS_ATOMIC=True FS_REMOTE=True FS_USER=1000:1000 FS_PERMS=644
DEBUG=False IS_TTY=True TZ=UTC SEARCH_BACKEND=sonic LDAP=False

[i] Dependency versions:
 √  PYTHON_BINARY         v3.11.7         valid     /usr/local/bin/python3.11
 √  SQLITE_BINARY         v2.6.0          valid     /usr/local/lib/python3.11/sqlite3/dbapi2.py
 √  DJANGO_BINARY         v3.1.14         valid     /usr/local/lib/python3.11/site-packages/django/__init__.py
 √  ARCHIVEBOX_BINARY     v0.7.1          valid     /usr/local/bin/archivebox

 √  CURL_BINARY           v8.4.0          valid     /usr/bin/curl
 √  WGET_BINARY           v1.21.3         valid     /usr/bin/wget
 √  NODE_BINARY           v20.10.0        valid     /usr/bin/node
 √  SINGLEFILE_BINARY     v1.1.46         valid     /app/node_modules/single-file-cli/single-file
 √  READABILITY_BINARY    v0.0.11         valid     /app/node_modules/readability-extractor/readability-extractor
 √  MERCURY_BINARY        v1.0.0          valid     /app/node_modules/@postlight/parser/cli.js
 √  GIT_BINARY            v2.39.2         valid     /usr/bin/git
 √  YOUTUBEDL_BINARY      v2023.12.30     valid     /usr/local/bin/yt-dlp
 √  CHROME_BINARY         v120.0.6099.28  valid     /usr/bin/chromium-browser
 √  RIPGREP_BINARY        v13.0.0         valid     /usr/bin/rg

[i] Source-code locations:
 √  PACKAGE_DIR           25 files        valid     /app/archivebox
 √  TEMPLATES_DIR         4 files         valid     /app/archivebox/templates
 -  CUSTOM_TEMPLATES_DIR  -               disabled  None

[i] Secrets locations:
 -  CHROME_USER_DATA_DIR  -               disabled  None
 -  COOKIES_FILE          -               disabled  None

[i] Data locations:
 √  OUTPUT_DIR            13 files @      valid     /data
 √  SOURCES_DIR           190 files       valid     ./sources
 √  LOGS_DIR              1 files         valid     ./logs
 √  ARCHIVE_DIR           120 files       valid     ./archive
 √  CONFIG_FILE           554.0 Bytes     valid     ./ArchiveBox.conf
 √  SQL_INDEX             1.7 MB          valid     ./index.sqlite3

pirate Jan 5, 2024
Maintainer

Should be fixed now, sorry, mind trying again? There is now a 0.7.2 image available.

gerroon Jan 5, 2024
Author

Thanks that seems to be fixed!

benmuth Jan 6, 2024

fyi @benmuth can you figure out a different way to pass the global context to only the admin views that need it?

Sure! For which views do you think we should display the upgrade notification? @pirate

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pull and resnapshot disappeared from the menu? #1306

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 2 comments 4 replies

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Select a reply

Pull and resnapshot disappeared from the menu? #1306

gerroon Jan 3, 2024

Replies: 2 comments · 4 replies

jack555444 Jan 3, 2024

pirate Jan 4, 2024 Maintainer

gerroon Jan 4, 2024 Author

pirate Jan 5, 2024 Maintainer

gerroon Jan 5, 2024 Author

benmuth Jan 6, 2024

gerroon
Jan 3, 2024

Replies: 2 comments 4 replies

jack555444
Jan 3, 2024

pirate
Jan 4, 2024
Maintainer

gerroon Jan 4, 2024
Author

pirate Jan 5, 2024
Maintainer

gerroon Jan 5, 2024
Author