Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Apply pep8 on leftover files from pr-merge #908

Merged
merged 3 commits into from
May 15, 2024
Merged

refactor: Apply pep8 on leftover files from pr-merge #908

merged 3 commits into from
May 15, 2024

Conversation

gaurarpit
Copy link
Collaborator

@gaurarpit gaurarpit commented May 15, 2024 •
edited

Purpose

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
  • Run the tests:
poetry run pytest -m "not azure and not functional"    
poetry run pytest -m "functional"

@gaurarpit gaurarpit self-assigned this May 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 15, 2024 •
edited

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL238367371% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
194 0 💤 0 ❌ 0 🔥 11.676s ⏱️

@gaurarpit gaurarpit marked this pull request as ready for review May 15, 2024 09:06
@cecheta
Copy link
Collaborator

cecheta commented May 15, 2024

While you're here, could you make test_Integrated_vectorization_embedder.py lowercase?

@gaurarpit gaurarpit marked this pull request as draft May 15, 2024 15:15
@gaurarpit gaurarpit marked this pull request as ready for review May 15, 2024 15:19
@gaurarpit gaurarpit changed the title refactor: Apply pep8 leftover file from pr-merge refactor: Apply pep8 on leftover file from pr-merge May 15, 2024
@gaurarpit gaurarpit changed the title refactor: Apply pep8 on leftover file from pr-merge refactor: Apply pep8 on leftover files from pr-merge May 15, 2024
@gaurarpit gaurarpit added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit c750216 May 15, 2024
16 checks passed
@gaurarpit gaurarpit deleted the arpit/refactor/leftover-pep8-file-from-prmerge branch May 15, 2024 15:35
liammoat pushed a commit that referenced this pull request May 16, 2024
@gaurarpit @liammoat
refactor: Apply pep8 on leftover files from pr-merge (#908)
676578d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cecheta cecheta cecheta approved these changes

Assignees

@gaurarpit gaurarpit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make backend package PEP8 compliant
2 participants
@gaurarpit @cecheta