Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Semantic Kernel functional tests to default #878

Open
cecheta opened this issue May 13, 2024 · 0 comments
Open

Move Semantic Kernel functional tests to default #878

cecheta opened this issue May 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@cecheta
Copy link
Collaborator

cecheta commented May 13, 2024

Motivation

Currently, the functional tests for Semantic Kernel spawn a separate instance of the application with the environment variable ORCHESTRATION_STRATEGY set to semantic_kernel. However, following #873 , it is now possible to mock the config retrieved from Azure Storage instead of relying on the default config, therefore the semantic kernel tests can be moved to the default suite of tests, with the config file retrieved from Azure storage to have .orchestrator.strategy set to semantic_kernel.

Requirements

A list of requirements to consider this feature delivered

  • Move all tests functional tests from sk_orchestrator to default
  • For these tests, mock the call to retrieve the file from Azure Storage with .orchestrator.strategy set to semantic_kernel.

Tasks

To be filled in by the engineer picking up the issue

@cecheta cecheta added the enhancement New feature or request label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant