Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for llm-chain #307

Closed
joshpopelka20 opened this issue May 14, 2024 · 2 comments
Closed

Add support for llm-chain #307

joshpopelka20 opened this issue May 14, 2024 · 2 comments

Comments

@joshpopelka20
Copy link
Contributor

joshpopelka20 commented May 14, 2024

Trying to use mistralrs with llamaindex, but it's still quite slow. For my use case, I'm trying to get performance in millisecs. With llamaindex, performance is not ideal.

I'm wondering if I can use mistralrs with llm-chain (it's a Rust-based alternative to llamaindex). I'd be willing to do the work to get the two to work together, but I'm not sure where to start. Can you let me know how I can integrate the two?

@EricLBuehler
Copy link
Owner

That sounds like a great idea.

To implement, the integration, I would recommend looking at how to connect their Executor trait with our Pipeline trait. Mistral.rs is designed around the Engine, which does the overseeing work of processing, scheduling, and running the Pipeline.

Currently, we don't have an embedding API, which we should probably add to implement this. I'm not very familiar with llm-chain so I'm not sure if that is a necessity. If it is, I'll try to add that API, as it has already been on my to-do list for some time.

@joshpopelka20
Copy link
Contributor Author

Thanks for the info.

I'm going to close this for now as I've got another project I'll be working on for the next few weeks. If I have the time afterward, I'll reopen the issue and work on the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants