Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some tools send DocumentMessage::Undo instead of DocumentMessage::AbortTransaction when Aborting #1663

Closed
milan-sedivy opened this issue Mar 9, 2024 · 2 comments · Fixed by #1664
Closed

Some tools send DocumentMessage::Undo instead of DocumentMessage::AbortTransaction when Aborting #1663

milan-sedivy opened this issue Mar 9, 2024 · 2 comments · Fixed by #1664
Assignees
@milan-sedivy
Labels
Bug Something isn't working Cleanup Changes to refactor or clean up messy code Rust Involves Rust programming for the backend
Milestone
Sprint 35

Comments

@milan-sedivy
Copy link
Contributor

Example of a tool with this behavior is "SelectTool".

DocumentMessage::Undo stores the history step, which can lead to the deletion of a previously stored redo step see #1659 and related Pull request for more information.
@milan-sedivy milan-sedivy mentioned this issue Mar 9, 2024
Merged
@Keavon Keavon added Bug Something isn't working Cleanup Changes to refactor or clean up messy code Rust Involves Rust programming for the backend labels Mar 9, 2024
@Keavon
Copy link
Member

Keavon commented May 8, 2024

Was this resolved by #1664? If so, we can close this, but I'm not sure if that PR did indeed resolve it or if this issue's part was left unfinished.

@Keavon
Copy link
Member

Keavon commented May 8, 2024

Presuming closed by #1664.

@Keavon Keavon closed this as completed May 8, 2024
@Keavon Keavon added this to the Sprint 35 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milan-sedivy milan-sedivy

Labels
Bug Something isn't working Cleanup Changes to refactor or clean up messy code Rust Involves Rust programming for the backend
Projects
Task Board
Archived in project
Milestone
Sprint 35
Development

Successfully merging a pull request may close this issue.

Fix cancellation of drag actions in all tools where it's missing milan-sedivy/Graphite
2 participants
@Keavon @milan-sedivy