Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The test suite uses our Promise polyfill #2814

Open
pygy opened this issue Jan 24, 2023 · 1 comment
Open

The test suite uses our Promise polyfill #2814

pygy opened this issue Jan 24, 2023 · 1 comment
Assignees
Labels
Type: Bug For bugs and any other unexpected breakage

Comments

@pygy
Copy link
Member

pygy commented Jan 24, 2023

The logic in ./promise/promise.js picks up the global window defined by the ./tests/test-api.js, doesn't find a Promise implementation, and goes on to use our polyfill instead of native promises.

Adding native promises to ./test-utils/broswerMock.js would solve this regardless of any future change in test loading order.

@pygy pygy added the Type: Bug For bugs and any other unexpected breakage label Jan 24, 2023
@pygy
Copy link
Member Author

pygy commented Jan 24, 2023

I fixed this in the v2.x branch, along with a perf regression in the test suite.

@StephanHoyer @dead-claudia Do you see this going into next as well?

ed2365d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug For bugs and any other unexpected breakage
Projects
None yet
Development

No branches or pull requests

2 participants