Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] - Deduplicate automatic trade whispers #46

Open
rmelcer opened this issue Jan 24, 2021 · 1 comment
Open

[FEATURE REQUEST] - Deduplicate automatic trade whispers #46

rmelcer opened this issue Jan 24, 2021 · 1 comment
Labels
feature New feature or request

Comments

@rmelcer
Copy link

rmelcer commented Jan 24, 2021

Is your feature request related to a problem? Please describe.
When a MercuryTrade user uses PoE Overlay's shortcuts (/hideout, /kick), MT will re-whisper old trade messages.

Ex:

  • User copies a trade message ("Hi, I'd like to buy your foo")
  • (good) MercuryTrade sends the trade message automatically
  • User uses a /command macro (ex: PoE Overlay's /hideout)
  • PoE Overlay runs "/hideout" in PoE, (changing the clipboard) then
  • returns the clipboard to the old state (changing the clipboard again)
  • The clipboard is again ("Hi, I'd like to buy your foo")
  • (bad) Mercury Trade resends the trade message again

Other minor problem:

  1. When MT starts or restarts, if your clipboard contains an old trade
    message, MT will resend it.
  2. When the user refreshes their item search page, they may lose track
    of which items they have already messaged. In this case, if they have
    already messaged for an item, MT will ping the seller again.

Describe the solution you'd like
I'd like MT to check the clipboard's contents against its history of previous trades, and skip resending the whisper if it was already sent recently (last 5-10 messages)
Describe alternatives you've considered
I tried to make this myself and it seemed to be working (#45), but after clearing my history, it broke again. When I dug into it more, it seems that MT only saves the message (Hi I'd like to buy your 2 chaos for my 10 alchemy) without including the recipient's name. This makes it impossible to de-duplicate across similar trades to different users - for example with multiple currency trades.
Additional context
Add any other context or screenshots about the feature request here.

@rmelcer rmelcer added the feature New feature or request label Jan 24, 2021
@rmelcer rmelcer changed the title [FEATURE REQUEST] - [FEATURE REQUEST] - Deduplicate automatic trade whispers Jan 24, 2021
@Morph21
Copy link
Owner

Morph21 commented Jan 26, 2021

you know that you can use /hideout macro in MT also? Just bind the shortcut. And here it's basically poe overlay fault for returning clipboard to the state which it was before. So to prevent this from happen MT would need to scan entire Client.txt file after each clipboard message which would be time consuming. Also MT is not saving history like in file or something. It's just in memory of running application so when you restart MT th history is lost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants