Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the entire spec more elegantly. #2

Open
javaun opened this issue Mar 11, 2024 · 0 comments
Open

Implement the entire spec more elegantly. #2

javaun opened this issue Mar 11, 2024 · 0 comments

Comments

@javaun
Copy link
Collaborator

javaun commented Mar 11, 2024

I must've just been flying through this. We should implement the full spec, and it should consistent and intuitive naming. This .model vs. .model_id is an example of it not being consistent.

self.model = formula_json.get('script', {}).get('model', {}) #['script']['model']
self.model_id = self.model.get('id', '') #['script']['model']['id']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant