Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trade search weapon type selection, currently only uses the equipped weapon type. #6832

Open
1 task done
guy1195 opened this issue Oct 18, 2023 · 0 comments · May be fixed by #7538
Open
1 task done

Trade search weapon type selection, currently only uses the equipped weapon type. #6832

guy1195 opened this issue Oct 18, 2023 · 0 comments · May be fixed by #7538
Labels
enhancement New feature, calculation, or mod

Comments

@guy1195
Copy link

guy1195 commented Oct 18, 2023

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Is your feature request related to a problem?

Currently, if I have a dagger equipped on my character (for example a spell damage dagger) the POB trade search will only try and find daggers. This may potentially miss mods on other weapon types that would greatly benefit your character.

I believe that the trade search should provide the option for a 'desired' weapon types, because if there is a wand/sceptre available that is more damage than my dagger, I would take it.

Describe the solution you'd like

The option to generate a trade search for a different weapon type compared to the currently equipped weapon. Simple dropdown that is pre-populated with the current equipped weapon type with the chance to change it.

Describe alternatives you've considered

I have changed the weapon type drop down after opening the trade URL, but this isn't possible inside the client when using poe session id, so you can't easily import/compare dps of items etc. Also i'm not sure all the possible mods are put into the weighted sum, because maybe some mods on a sceptre aren't on a dagger etc?

Additional context

No response

@guy1195 guy1195 added the enhancement New feature, calculation, or mod label Oct 18, 2023
mcmanustfj added a commit to mcmanustfj/PathOfBuilding that referenced this issue Apr 4, 2024
@mcmanustfj mcmanustfj linked a pull request Apr 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant