Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find Timeless Jewel's league-selection is not updated for trade site url unless manually triggered #7564

Open
2 tasks done
tbiering opened this issue Apr 13, 2024 · 0 comments · May be fixed by #7565
Open
2 tasks done
Labels
bug Something isn't working

Comments

@tbiering
Copy link

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate open and closed issues by using the search function of the issue tracker

How is Path of Building expected to behave?

When opening the "Find Timeless Jewel" window, the user can search for jewels and copy a corresponding trade search URL. The trade search URL should use the league selected in the dropdown next to it.
https://www.pathofexile.com/trade/search/Necropolis/?q=%7B%22query%22%3A%7B%22status[...]

How does Path of Building behave?

The url copied to the clipboard does not contain the league until the user changes the dropdown value at least once to update the internal variable.
The league part of the url defaults to an empty string:
https://www.pathofexile.com/trade/search//?q=%7B%22query%22%3A%7B%22status[...]

In this case, the trade site itself does redirect to a default league, which is updated on the server-side on GGGs end. During (at least) the first 10 days of Necropolis league, this specific default was not updated to the current active league, but was still configured to "Standard". This caused any searches to be performed on the Standard league of the trade site, even when the current active league was populated as the first entry of the dropdown in POB's find timeless jewel window.

In order to no longer rely on GGGs update of the default redirect of the trade site, the URL should always contain the selected league from the dropdown. Only in cases where the currently active leagues are unable to be fetched by POB, the url should default to GGGs redirect.

Additionally, POB "forgets" the league that was selected the last time the window was open during a session.

How to reproduce the issue

  1. Import build from URL
  2. Open "Find Timeless Jewel" window in the Tree view
  3. Set search parameters (this should already be configured when using my exported build)
  4. Click on "Search"
  5. Click on "Copy Trade URL"
  6. Check URL in clipboard
    The url in the clipboard does not contain the league that is pre-populated in the dropdown, but is empty.
    https://www.pathofexile.com/trade/search//?q=%7B%22query%22%3A%7B%22status[...]

Character build code

https://pobb.in/9vaXc8d1NeLX

Screenshots

No response

@tbiering tbiering added the bug Something isn't working label Apr 13, 2024
@tbiering tbiering linked a pull request Apr 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant