Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke-WebRequest needs SupportsShouldProcess #23806

Open
jdhitsolutions opened this issue May 15, 2024 · 0 comments
Open

Invoke-WebRequest needs SupportsShouldProcess #23806

jdhitsolutions opened this issue May 15, 2024 · 0 comments
Labels
Issue-Enhancement the issue is more of a feature request than a bug Needs-Triage The issue is new and needs to be triaged by a work group. WG-Cmdlets-Utility cmdlets in the Microsoft.PowerShell.Utility module

Comments

@jdhitsolutions
Copy link
Collaborator

Summary of the new feature / enhancement

Because Invoke-WebRequest might change the state of a system, it should support -WhatIf`` and ``Confirm. Even if we aren't concerned about changing the state of a web item via a Post or Patch operation, Invoke-WebRequest can create local files which we should process with -WhatIf.

Proposed technical implementation details (optional)

Cmdlet binding should add SupportsShouldProcess and messaging should be very clear about what operation is being handled. -WhatIf should only be applied to any operation other than a GET and those that involve modifying the local filesystem.

@jdhitsolutions jdhitsolutions added Issue-Enhancement the issue is more of a feature request than a bug Needs-Triage The issue is new and needs to be triaged by a work group. labels May 15, 2024
@StevenBucher98 StevenBucher98 added the WG-Cmdlets-Utility cmdlets in the Microsoft.PowerShell.Utility module label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement the issue is more of a feature request than a bug Needs-Triage The issue is new and needs to be triaged by a work group. WG-Cmdlets-Utility cmdlets in the Microsoft.PowerShell.Utility module
Projects
None yet
Development

No branches or pull requests

2 participants