Follow symlinks for traductions - Deployer best practice #36160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeremie-Kiwik
commented
May 14, 2024
•
Jeremie-Kiwik
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | The Finder used to search translation files does not follow symlinks by default. This is a major issue when working with modern and robust solutions like Deployer. On these environments, each GIT release is in a specific folder, and the "living" files (traductions, images...) are in a common shared folder. Symlinks are then created to point to the shared folder. Currently, all translation files are ignored by PrestaShop, as they are symlinks. This PR aims to integrate them. |
| Type? | bug fix |
| Category? | CO |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | Move a traduction file from app/Resources/translations or from your theme to somewhere else, and make a symlink to it (ie: ln -fs /moved_file /original/location) |
| UI Tests | |
| Fixed issue or discussion? | Fixes #36161 |
| Related PRs | |
| Sponsor company | KIWIK (kiwik.com) |
The Finder used to search traduction files does not follow symlinks by default. Which is a major problem when working with modern and robust solutions like Deployer. On those environments, each GIT release is in a specific folder, and the "living" files (traductions, images...) are in a common shared folder. And symlinks are made to point to the shared folder. So for now, all the traduction files are ignored by Presta, as they are symlinks. This PR aims to integrate them
|
Hello @Jeremie-Kiwik! This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community! |
|
Hi, thanks for this contribution! I found some issues with the Pull Request description:
Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much! About linked issuesPlease consider opening an issue before submitting a Pull Request:
(Note: this is an automated message, but answering it will reach a real human) |
kpodemski
requested changes
May 15, 2024
There was a problem hiding this comment.
Thanks @Jeremie-Kiwik
To respect coding standards of the project you should use spaces instead of tabs ;-)
ps-jarvis
added
the
Waiting for author
Remplace tabs by spaces
|
You're right. Here it is! |
PrestaEdit
approved these changes
May 16, 2024
PululuK
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.