Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support location awareness for materialized view #45738

Merged
merged 2 commits into from
May 20, 2024
Merged

[Feature] Support location awareness for materialized view #45738

merged 2 commits into from
May 20, 2024

Conversation

nshangyiming
Copy link
Contributor

@nshangyiming nshangyiming commented May 16, 2024 •
edited

Fixes SR-27282
Fixes #45739

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@nshangyiming nshangyiming requested a review from a team as a code owner May 16, 2024 08:52
@wanpengfei-git wanpengfei-git requested a review from a team May 16, 2024 08:53
@nshangyiming
[Feature] Support location awareness for materialized view
b1f8c38 
Signed-off-by: Dejun Xia <xiadejun@starrocks.com>
@nshangyiming
fix ut
e008e5f 
Signed-off-by: Dejun Xia <xiadejun@starrocks.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
27 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 183 / 201 (91.04%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/common/util/PropertyAnalyzer.java 159 177 89.83% [1349, 1354, 1355, 1370, 1387, 1398, 1420, 1436, 1533, 1534, 1535, 1536, 1568, 1569, 1571, 1598, 1599, 1600]
🔵 com/starrocks/server/OlapTableFactory.java 1 1 100.00% []
🔵 com/starrocks/system/SystemInfoService.java 16 16 100.00% []
🔵 com/starrocks/server/LocalMetastore.java 3 3 100.00% []
🔵 com/starrocks/alter/AlterMVJobExecutor.java 3 3 100.00% []
🔵 com/starrocks/persist/EditLog.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@nshangyiming nshangyiming removed the request for review from a team May 20, 2024 02:08
@nshangyiming nshangyiming enabled auto-merge (squash) May 20, 2024 02:08
@nshangyiming nshangyiming merged commit 4c5f961 into StarRocks:main May 20, 2024
46 checks passed
@wanpengfei-git wanpengfei-git mentioned this pull request May 20, 2024
Closed
2 tasks
node pushed a commit to vivo/starrocks that referenced this pull request May 20, 2024
@nshangyiming @node
[Feature] Support location awareness for materialized view (StarRocks…
c4e9279 
…#45738)

Signed-off-by: Dejun Xia <xiadejun@starrocks.com>
@nshangyiming
Copy link
Contributor Author

@mergify backport branch-3.3

@mergify Mergify
Copy link
Contributor

mergify bot commented May 20, 2024 •
edited

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 20, 2024
@nshangyiming @mergify
[Feature] Support location awareness for materialized view (#45738)
4c232b7 
Signed-off-by: Dejun Xia <xiadejun@starrocks.com>
(cherry picked from commit 4c5f961)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/server/LocalMetastore.java
@mergify mergify bot mentioned this pull request May 20, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request May 20, 2024
@mergify @nshangyiming
[Feature] Support location awareness for materialized view (backport #…
1376988 
…45738) (#45913)

Signed-off-by: yiming <xiadejun@starrocks.com>
Co-authored-by: yiming <xiadejun@starrocks.com>
nshangyiming added a commit to nshangyiming/starrocks that referenced this pull request May 24, 2024
@mergify @nshangyiming
[Feature] Support location awareness for materialized view (backport S…
9804a95 
…tarRocks#45738) (StarRocks#45913)

Signed-off-by: yiming <xiadejun@starrocks.com>
Co-authored-by: yiming <xiadejun@starrocks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr left review comments

@HangyuanLiu HangyuanLiu HangyuanLiu approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

Assignees

@nshangyiming nshangyiming

Labels
3.3-merged META-REVIEW version:3.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support location awareness for materialized view
4 participants
@nshangyiming @HangyuanLiu @gengjun-git @wanpengfei-git