Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't draw stellar halos if the star is obscured #1924

Open
Atque opened this issue Sep 26, 2021 · 7 comments · May be fixed by #1959
Open

Don't draw stellar halos if the star is obscured #1924

Atque opened this issue Sep 26, 2021 · 7 comments · May be fixed by #1959
Labels
importance: low Small problem, rarely visible, no crash wishlist Long-term ideas

Comments

@Atque
Copy link
Contributor

Atque commented Sep 26, 2021

Now that annual aberration is implemented and we have very accurate lunar positions in relation to stars, it might be advisable to hide an occulted star's halo completely when the Moon or whatever obscures it. The screenshot below shows an occultation of 19 Piscium by the Moon, and the star's halo is still visible, despite the star actually being hidden behind the lunar disc.

stellarium-112

I think this has been up for discussion earlier, but there is no formal report of it.

The same might be wished for when a planet disk is completely hidden behind the Moon or another planet.

@gzotti
Copy link
Member

gzotti commented Sep 26, 2021

Sure this "would be nice". Just that there is no test for stellar obscuration, we just plot the stars and then overdraw the Moon. It may be possible to hide planet halos by testing ~200 solar system objects, but please understand that testing every single star against obscuration by the Moon before we plot it is simply (almost certainly -- correct me by sending a PR that proves otherwise!) not advisable in an interactive application.

@gzotti gzotti added importance: low Small problem, rarely visible, no crash wishlist Long-term ideas labels Sep 26, 2021
@Atque
Copy link
Contributor Author

Atque commented Sep 26, 2021

Ah, it is more complicated and demanding than I tought. Maybe it is possible to circumnavigate that in some way,

@github-actions
Copy link

Hello @Atque! Thank you for this suggestion.

@alex-w alex-w added this to To do in Visualization via automation Sep 29, 2021
@gzotti gzotti linked a pull request Oct 9, 2021 that will close this issue
12 tasks
@gzotti
Copy link
Member

gzotti commented Oct 9, 2021

I tried with a simple test. However, the Moon is rendered as tessellated sphere (i.e. its geometry is like a multi-faceted "disco ball") and therefore can be some arcseconds smaller than it should be. (BTW, this also means occultation times cannot be super-accurate!) In this case stars vanish a few arcseconds besides the Moon. This is also bad, although the first such star I observed turned out to be a close double. Yes, the effect is great! But we need a better test. See #1959.

@guillaumechereau
Copy link
Contributor

Thinking about it, an other issue here is that the halo of a star very close to the Moon edge should be seen in front of the Moon I think. See the fake screenshot attached. Is that correct?

image

@Atque
Copy link
Contributor Author

Atque commented Oct 26, 2021

@guillaumechereau Yes, technically they should be drawn in front of planets etc (at least until its center is covered). The star texture represents its glare, which is not physical but an optical illusion.

@gzotti
Copy link
Member

gzotti commented Oct 26, 2021

Yes, indeed. This would be even better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
importance: low Small problem, rarely visible, no crash wishlist Long-term ideas
Projects
Visualization
  
To do
Development

Successfully merging a pull request may close this issue.

3 participants