Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a collage seems to not be running in the background #91

Open
SirPhilip3 opened this issue Apr 29, 2024 · 2 comments
Open

Creating a collage seems to not be running in the background #91

SirPhilip3 opened this issue Apr 29, 2024 · 2 comments
Labels
enhancement New feature or request quality of life A quality of life (QoL) enhancement or suggestion

Comments

@SirPhilip3
Copy link

SirPhilip3 commented Apr 29, 2024

When creating a new collage, it appears that the main thread halts until the image creation and saving process is finished. Creating a background process for these operations should resolve the issue

@CyanVoxel CyanVoxel added enhancement New feature or request quality of life A quality of life (QoL) enhancement or suggestion labels Apr 30, 2024
@CyanVoxel
Copy link
Member

The collage feature is currently "half-implemented", where it was an unfinished feature that was brought forward to this version of the program. In other words, it's not a fully complete feature yet, but in time it will be easier to use and interact with, including not mysteriously locking up the main thread in the background.

@SirPhilip3
Copy link
Author

The issue seems to be caused by this line :

time.sleep(5)

Removing it resolves the issue of halting the main app thread , ther's still lag when the image file is saved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request quality of life A quality of life (QoL) enhancement or suggestion
Projects
None yet
Development

No branches or pull requests

2 participants