Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOMNode.workers is a confusing alias #3619

Open
rodrigogiraoserrao opened this issue Oct 31, 2023 · 1 comment · May be fixed by #4515
Open

DOMNode.workers is a confusing alias #3619

rodrigogiraoserrao opened this issue Oct 31, 2023 · 1 comment · May be fixed by #4515
Labels
enhancement New feature or request question Further information is requested Task

Comments

@rodrigogiraoserrao
Copy link
Contributor

Currently, DOMNode.workers is a very confusing alias for App.workers.

When you type self.workers inside a widget, it really, really, REALLY looks like you are talking about the workers started by/associated with the given widget.
But you're actually talking about all app workers.

See #3615 (comment) for some extra context.

I suggest we rename DOMNode.workers to DOMNode.app_workers and/or make it so that DOMNode.workers retrieves all workers started by/associated with the given widget.
@rodrigogiraoserrao rodrigogiraoserrao added enhancement New feature or request question Further information is requested Task labels Oct 31, 2023
@davep
Copy link
Collaborator

davep commented Oct 31, 2023

Big second.

@TomJGooding TomJGooding linked a pull request May 15, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: remove confusing app workers alias TomJGooding/textual
2 participants
@davep @rodrigogiraoserrao