Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of ECDSA #194

Open
blaggacao opened this issue Oct 12, 2020 · 5 comments
Open

Support of ECDSA #194

blaggacao opened this issue Oct 12, 2020 · 5 comments

Comments

@blaggacao
Copy link
Contributor

blaggacao commented Oct 12, 2020

don't use ECDSA as it's not supported currently

However it looks as if spiffe SVID's are EC keys 😕

cat /tls/svid_key.pem
-----BEGIN EC PRIVATE KEY-----
MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgmpfbqNxh2xD4L54j
gjZG3etUNQbEJCvTP+JUTVotOJihRANCAASV+Amcy6jWEeqn6cnFCjbFcRrRcyG8
yauvxlUY3VRp/6v5SUTsM/VxiTw5GgQHAdr4NlZm+BlW0/oYAtpAQFgE
-----END EC PRIVATE KEY-----

Unfortunately, fore spire, as result of their secure default policy, it's hard coded

@blaggacao

This comment has been minimized.

@blaggacao
Copy link
Contributor Author

blaggacao commented Oct 12, 2020

marching through the institutions

@amouat
Copy link
Contributor

amouat commented Oct 13, 2020

Well done digging into the underlying code!

We're currently in the middle of refactoring the code to swap from Rocket to Actix, but will probably still use rustls as the underlying TLS implementation.

What do you want to happen with this issue? It seems to be outside of the control of this repo. We could keep it with a "blocked" label, but then I would like a simple test so that we can check when it does start working.

@blaggacao
Copy link
Contributor Author

Yeah a test sounds like an excellent idea! I'll throw something together today.

@blaggacao
Copy link
Contributor Author

@amouat rwf2/Rocket@af48d1f

It looks like this just unblocked. I would be very keen to be able to end-to-end test my poc setup from half a year ago on hope to retake where I had to stop.

Could you bump the rocket version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Trow
  
To do
Development

No branches or pull requests

2 participants