Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GET status of resumable uploads #223

Open
amouat opened this issue Nov 22, 2020 · 0 comments
Open

Support GET status of resumable uploads #223

amouat opened this issue Nov 22, 2020 · 0 comments

Comments

@amouat
Copy link
Contributor

amouat commented Nov 22, 2020

This seems to be missing from Trow:

https://github.com/opencontainers/distribution-spec/blob/master/detail.md#blob-upload

But to be honest I'm not sure the whole resumable upload thing actually works properly anywhere. It seems to be only half implemented in Docker Distribution, and only as of late 2019: https://github.com/docker/distribution/blob/6c72ec2e8514dbe3a96506316f80351ed95313a1/registry/handlers/blobupload.go#L136 . For this reason, I've only labelled it enhancement.

We should still try to implement it, going by the spec, but even that seems a little inconsistent about what headers are returned when and in what format e.g. should it start "bytes="? Shouldn't it be symmetrical with the fetch blob part calls (which we also don't implement...).

We also need proper tests for all this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant