Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

希望优化一下代码 #3287

Closed
ChenJiaXin520 opened this issue May 16, 2024 · 2 comments
Closed

希望优化一下代码 #3287

ChenJiaXin520 opened this issue May 16, 2024 · 2 comments

Comments

@ChenJiaXin520
Copy link

我提交过两个简单的pr,查看项目代码的时候发现wxjava-java-mp公众号模块的RequestExecutor的实现类有很多重复代码,例如:
HttpPost httpPost = new HttpPost(uri);
if (requestHttp.getRequestHttpProxy() != null) {
RequestConfig config = RequestConfig.custom().setProxy(requestHttp.getRequestHttpProxy()).build();
httpPost.setConfig(config);
}
另外还有RequestHttp这个泛型类使用也不规范,很多类在使用中并没有明确指明泛型的类型

@ChenJiaXin520 ChenJiaXin520 changed the title 建议优化一下代码 希望优化一下代码 May 16, 2024
@binarywang
Copy link
Member

你可以直接提交PR进行优化吧

@ChenJiaXin520
Copy link
Author

牵涉有点多,改动比较大,建议还是你们主力开发者修改

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants