Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command row input type as number when applicable #116

Open
kochrt opened this issue Oct 22, 2023 · 1 comment
Open

Command row input type as number when applicable #116

kochrt opened this issue Oct 22, 2023 · 1 comment

Comments

@kochrt
Copy link

kochrt commented Oct 22, 2023

I'm wondering if it's possible to have this input be type="number" when it's referring to a number so keyboard keys (up & down) can be used to increment/decrement the value.

I'd open a PR but I don't know under what conditions the value is a number.

@Yqnn
Copy link
Owner

Yqnn commented Oct 27, 2023

I wouldn't advocate using type="number" :

  • it adds some ungraceful stepper arrows inside the field, that can be removed only using some nonstandard CSS properties.
image
  • it would break the current keyboard navigation: up & down arrows are used to move between rows.
  • I'm not sure what should be put as step value: 1, 0.1, 0.01, 0.001 or something dynamic depending on point precision ?

Alternatives:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants