New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onBrushEnd infinite render loop #1819

Closed

balbany opened this issue Apr 15, 2024 · 1 comment

balbany commented Apr 15, 2024

Looks like @visx/brush has an infinite render loop bug (when used with useWindowMoveEvents).

To reproduce:

Using the standard brush example from the docs, repoint the onBrushChange handler to be triggered by onBrushEnd.
Now change the brush position more than once in quick succession. You should get the below error:

Sounds similar to #1283 (due to the involvement of useWindowMoveEvents).

Thanks 🙏

The text was updated successfully, but these errors were encountered:

Member

hshoff commented May 27, 2024

Hi @balbany, this seems fixed now. Can see it working here on my fork of the example here: https://codesandbox.io/p/sandbox/vigilant-edison-p9pzjv?file=%2FExample.tsx%3A215%2C1-216%2C1

hshoff closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment