Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making mssql provider to support only mssql+pymssql dialect #39586

Open
2 tasks done
rawwar opened this issue May 13, 2024 · 1 comment
Open
2 tasks done

Making mssql provider to support only mssql+pymssql dialect #39586

rawwar opened this issue May 13, 2024 · 1 comment
Labels
kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet provider:microsoft-mssql

Comments

@rawwar
Copy link
Collaborator

rawwar commented May 13, 2024

Description

Currently, we allow users to pass dialect via sqlalchemy_scheme extra field of the mssql connections.

def sqlalchemy_scheme(self) -> str:

I am proposing to remove this field as it is not possible to support multiple dialects without installing the relevant dialect driver. Also, the documentation page does not even mention about sqlalchemy_scheme or the possibility of using other dialects.

Use case/motivation

Supporting multiple dialects requires the installation of multiple drivers. Since we only install pymssql, this allows the usage of the mssql+pymssql dialect alone and not others.

I am also interested in updating the documentation to reflect this.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@rawwar rawwar added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet provider:microsoft-mssql labels May 13, 2024
@rawwar
Copy link
Collaborator Author

rawwar commented May 14, 2024

@Taragolis , requesting your comments on this.

I was working on updating mssql provider to use sqlalchemy_url property in get_uri and got the idea for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet provider:microsoft-mssql
Projects
None yet
Development

No branches or pull requests

1 participant