Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct the default collector config apisix actually used for opentelemetry plugin #11247

Merged
merged 11 commits into from
May 30, 2024
Merged

docs: correct the default collector config apisix actually used for opentelemetry plugin #11247

merged 11 commits into from
May 30, 2024

Conversation

flea1lt
Copy link
Contributor

@flea1lt flea1lt commented May 11, 2024

Description

Fixes #11242

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@flea1lt flea1lt changed the title Fix/opentelemetry docs: opentelemetry May 11, 2024
@flea1lt flea1lt changed the title docs: opentelemetry fix(opentelemetry): correct the default value for the opentelemetry plugin attr and update the docs May 11, 2024
kayx23
kayx23 reviewed May 12, 2024
View reviewed changes
docs/en/latest/plugins/opentelemetry.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/opentelemetry.md Outdated Show resolved Hide resolved
@flea1lt
Copy link
Contributor Author

flea1lt commented May 13, 2024

@kayx23 PTAL

kayx23
kayx23 previously approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@kayx23 kayx23 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shreemaan-abhishek please help review change in conf/config-default.yaml. I have checked that the updated values are indeed the default in the .lua file but have no context for why they were different in the very beginning.

The failing CI is FIPS and doesn't seem relevant.

@flea1lt
Copy link
Contributor Author

flea1lt commented May 16, 2024

@kayx23 @shreemaan-abhishek PTAL

@flea1lt flea1lt changed the title fix(opentelemetry): correct the default value for the opentelemetry plugin attr and update the docs docs: correct the default collector config apisix actually used for opentelemetry plugin May 16, 2024
@yzeng25 yzeng25 requested a review from kayx23 May 17, 2024 05:49
@flea1lt
Copy link
Contributor Author

flea1lt commented May 27, 2024 •
edited

@kayx23 @shreemaan-abhishek Any suggestion?

@flea1lt
Copy link
Contributor Author

flea1lt commented May 28, 2024

@kayx23 Please review.

@flea1lt
Copy link
Contributor Author

flea1lt commented May 30, 2024

@shreemaan-abhishek PTAL

@kayx23 kayx23 requested a review from pottekkat May 30, 2024 03:52
@pottekkat pottekkat merged commit 55eeb6b into apache:master May 30, 2024
7 checks passed
@flea1lt flea1lt deleted the fix/opentelemetry branch May 30, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonming moonming moonming approved these changes

@kayx23 kayx23 kayx23 approved these changes

@pottekkat pottekkat pottekkat approved these changes

@shreemaan-abhishek shreemaan-abhishek Awaiting requested review from shreemaan-abhishek

@Revolyssup Revolyssup Awaiting requested review from Revolyssup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@flea1lt @moonming @kayx23 @pottekkat @shreemaan-abhishek