Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: nacos node failure should not corrupt in-memory data #11252

Open
zuiyangqingzhou opened this issue May 15, 2024 · 0 comments · May be fixed by #11253
Open

bug: nacos node failure should not corrupt in-memory data #11252

zuiyangqingzhou opened this issue May 15, 2024 · 0 comments · May be fixed by #11253

Comments

@zuiyangqingzhou
Copy link
Contributor

Current Behavior

https://github.com/apache/apisix/blob/master/apisix/discovery/nacos/init.lua#L354-L358

The above code logic only determines whether the MD5 value of the new data is equal to that of the data in memory, but does not verify that the new data obtained is empty.

Because if an exception occurs in the nacos service, the new data obtained may be empty, causing the data in memory to be updated incorrectly.

Expected Behavior

nacos node failure should not corrupt in-memory data

Error Logs

No response

Steps to Reproduce

  1. start apisix normally and configure nacos service discovery
  2. you need to set the nacos service as a failure while the service is running. (Note that nacos services do not require authentication)

Environment

  • APISIX version (run apisix version):
  • Operating system (run uname -a):
  • OpenResty / Nginx version (run openresty -V or nginx -V):
  • etcd version, if relevant (run curl http://127.0.0.1:9090/v1/server_info):
  • APISIX Dashboard version, if relevant:
  • Plugin runner version, for issues related to plugin runners:
  • LuaRocks version, for installation issues (run luarocks --version):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

1 participant