Revamp the Asynchronous logging page
#2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
referenced
this pull request
May 14, 2024
We refresh the asynchronous logging page by: * marking more clearly that _asynchronous logging_ is not the solution to all performance problems. Depending on the case it could give all disadvantage of async processing without any measurable advantages. * removes the system properties and points to the appropriate "Configuration properties" section. * refreshes the configuration examples by adding an example for each of the configuration formats. Closes #2534.
vy
requested changes
May 16, 2024
src/site/antora/modules/ROOT/examples/manual/configuration/custom-wait-strategy.xml
Outdated
Show resolved
Hide resolved
src/site/antora/modules/ROOT/examples/manual/configuration/mixed-async.json
Outdated
Show resolved
Hide resolved
src/site/antora/modules/ROOT/examples/manual/configuration/mixed-async.properties
Outdated
Show resolved
Hide resolved
src/site/antora/modules/ROOT/examples/manual/configuration/mixed-async.xml
Outdated
Show resolved
Hide resolved
src/site/antora/modules/ROOT/examples/manual/configuration/mixed-async.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
# Conflicts: # src/site/antora/modules/ROOT/pages/manual/async.adoc # src/site/antora/modules/ROOT/pages/manual/garbagefree.adoc
vy
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We refresh the asynchronous logging page by:
Closes #2534.