Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Whole database compression combined mode does not support append unware bucket table #2670

Closed
1 of 2 tasks
thomasg19930417 opened this issue Jan 10, 2024 · 4 comments · Fixed by #2858
Closed
1 of 2 tasks
Assignees
Labels
enhancement New feature or request

Comments

@thomasg19930417
Copy link

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

Whole database compression combined mode does not support append unware bucket table。
f7467db14a7d8d34906f776d5695c4e3

Solution

No response

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@thomasg19930417 thomasg19930417 added the enhancement New feature or request label Jan 10, 2024
@yuzelin yuzelin self-assigned this Jan 11, 2024
@wg1026688210
Copy link
Contributor

assign to me plz

@wg1026688210
Copy link
Contributor

Hi~ @thomasg19930417 Can you provide the command ?

@thomasg19930417
Copy link
Author

Hi~ @thomasg19930417 Can you provide the command ?

Use the entire database compression command and specify the compression mode --mode combined, and the table is an append table. There are no other special parameters.

@wg1026688210
Copy link
Contributor

wg1026688210 commented Apr 8, 2024

I will fix this issue by breaking it down into several subtasks, which will be better to review.

  1. support specify database and table in AppendOnlyCompactionTask [compaction] support multi table AppendOnlyCompactionTask #3174
  2. support compact unaware bucket for combine_mode [compaction]refact compaction work operator for supporting multi unaware bucket tables. #3175
  3. refact the file scan source of combine mode for supporting unaware logic [compaction] Refact the file scan source of combine mode for supporting unaware logic #3179
  4. use refacted combined compaction implement [compaction] use refacted combined compaction operator #3182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants