Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core]tag create time nullable #3289

Merged
merged 4 commits into from May 4, 2024
Merged

[core]tag create time nullable #3289

merged 4 commits into from May 4, 2024

Conversation

eric666666
Copy link
Contributor

Purpose

Linked issue: close #3280

Tests

API and Format

Documentation

@eric666666
Copy link
Contributor Author

@Zouxxyy @JingsongLi Please have a review.

JingsongLi
JingsongLi reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just set new DataField(6, "create_time", new TimestampType(false, 3)) to new DataField(6, "create_time", new TimestampType(3)) and return null directly?

@eric666666
Copy link
Contributor Author

Can we just set new DataField(6, "create_time", new TimestampType(false, 3)) to new DataField(6, "create_time", new TimestampType(3)) and return null directly?
@JingsongLi Okay, I push a new commit with your thoughts. And it works.

+-------------+-----------+---------+-----------------------+------------+--------+-----------+-------------+
|tag_name     |snapshot_id|schema_id|commit_time            |record_count|branches|create_time|time_retained|
+-------------+-----------+---------+-----------------------+------------+--------+-----------+-------------+
|2024-04-29 15|1          |0        |2024-04-29 16:39:58.639|2531        |[]      |null       |             |
|2024-04-29 18|19         |0        |2024-04-29 16:51:00.805|2542        |[]      |null       |             |
|2024-04-29 21|49         |0        |2024-04-29 17:04:05.326|2556        |[]      |null       |             |
+-------------+-----------+---------+-----------------------+------------+--------+-----------+-------------+

@eric666666 eric666666 changed the title [core]tag default create time use epoch time [core]tag create time nullable Apr 30, 2024
@JingsongLi
Copy link
Contributor

@eric666666 good new!

@eric666666
Copy link
Contributor Author

@eric666666 good new!

@JingsongLi I forgot check format violations,and I just repaired it, please trigger workflows again.

@JingsongLi
Copy link
Contributor

Please fix TagsTableTest.testTagsTable.

@eric666666
Copy link
Contributor Author

Please fix TagsTableTest.testTagsTable.

@JingsongLi Okay, next time I will pay attention to running the test class locally first.

@JingsongLi
Copy link
Contributor

+1

@JingsongLi JingsongLi merged commit b53c368 into apache:master May 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingsongLi JingsongLi JingsongLi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] paimon 0.8 spark read tag error
2 participants
@eric666666 @JingsongLi