Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8137] Support pop consumption for light message queue #8138

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

HScarb
Copy link
Contributor

@HScarb HScarb commented May 14, 2024

Which Issue(s) This PR Fixes

Fixes #8137

Brief Description

Support server-side rebalance for light message queues.
Add light message queue consume demos.

How Did You Test This Change?

UT, local test

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.84%. Comparing base (6091968) to head (f6e9b5b).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8138      +/-   ##
=============================================
- Coverage      42.89%   42.84%   -0.06%     
+ Complexity     10375    10364      -11     
=============================================
  Files           1270     1270              
  Lines          88694    88697       +3     
  Branches       11401    11402       +1     
=============================================
- Hits           38048    38001      -47     
- Misses         45954    45991      +37     
- Partials        4692     4705      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cserwen

This comment was marked as outdated.

if (MixAll.isLmq(topic)) {
mqSet = new HashSet<>();
mqSet.add(new MessageQueue(
topic, brokerController.getBrokerConfig().getBrokerName(), (int)MixAll.LMQ_QUEUE_ID));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to find all mqs for lmq topic when there are multi brokers?

@cserwen cserwen self-requested a review May 24, 2024 03:57
@cserwen cserwen removed their request for review May 24, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support pop consumption for light message queue (LMQ)
3 participants