New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does synchronized block required for method "addMetric(String name, Metric metric)" in "AbstractMetricsContext" class? #6782

Open

arjun12102019 opened this issue Apr 30, 2024 · 0 comments

arjun12102019 commented Apr 30, 2024

Why do we require explicit thread safety using synchronized block for "metrics" map in "AbstractMetricsContext" class.

metrics is concurrentHashmap and which will take care of thread safety by default for "get" and "put" operations.

Please confirm about my understanding, So that I will make changes and raise PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment