-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Changing font causes visual distortion; more noticeable than what used to happen on the base DP #33331
Comments
Seems like we're propagating changes to tokens in two steps rather than applying them everywhere at once? |
I think the visual distortion is expected no? 🤔 Since different fonts have different character widths which is causing the width of widget change on font change. I am not sure what is the expectation here? @ichik @ramsaptami |
@jsartisan there's 2 parts to the video, first bit shows behaviour on the widget selection DP & second half on the previous version of the base DP - you'll notice the transition is smoother on the latter. |
@jsartisan it's about two reflows that happen. If you watch the video closely you can see that adjustments happens in two steps after typeface change. |
Related conversation #33374 (comment) |
@jsartisan please add estimates if we're working on this; we can move this to the backlog if this isn't being picked up right now too |
@ramsaptami Moved task to new issues list because it's low priority and we'll postpone it for a while. |
Is there an existing issue for this?
Description
changing font causes visual distortion; more noticeable than what used to happen on the base DP
Steps To Reproduce
Public Sample App
No response
Environment
Deploy Preview
Severity
High
Issue video log
https://www.loom.com/share/fd8ad97824324fe2b74c87a3d58bb526?sid=3539c3ff-46ff-4d26-a5d4-e1e9dbc44541
Version
cloud
The text was updated successfully, but these errors were encountered: