[Bug]: Privacy policy and Terms and Conditions pages fonts are not updated. #33427
Closed
1 task done
Assignees
Labels
ads revamp
All issues related to ads revamp.
Bug
Something isn't working
Design System Pod
Appsmith design system related issues
IDE
Issues related to the IDE
Low
An issue that is neither critical nor breaks a user flow
Medium
Issues that frustrate users due to poor UX
Needs Triaging
Needs attention from maintainers to triage
New Developers Pod
Issues that new developers face while exploring the IDE
Production
QA Pod
Issues under the QA Pod
QA
Needs QA attention
Comments
btsgh
added
Bug
Nikhil-Nandagopal
added
the
Low
github-actions
bot
added
New Developers Pod
|
Hello, I am interested in picking up this issue as part of my first open source contribution. I am a student contributing as an assignment in university so any guidance as to where to start would be much appreciated. Thank you! |
|
@zoispyridi thank you for your interest! You can check out the contribution guide here: https://github.com/appsmithorg/appsmith/blob/master/CONTRIBUTING.md |
|
@rohan-arthur thank you for directing me to contribution guide!Could you please clarify the preferred font style to be used for the text content on these pages? Your guidance on this matter would greatly assist me in ensuring that the styling of these pages meets the project's requirements. Thank you!! |
2 tasks
albinAppsmith
added a commit
that referenced
this issue
Jun 5, 2024
## Description Privacy and Term & conditions pages was not using latest platform font PT root since it was served as normal HTML files. This PR addresses that issue. Fixes #33427 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9382277755> > Commit: 75416ef > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9382277755&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced new font styling across various pages using the PT Root UI font family for a consistent look and feel. - **Style** - Updated `404.html`, `privacy-policy.html`, and `terms-and-conditions.html` to include a link to the new `font-style.css` stylesheet. - Removed redundant `font-family` declarations from `privacy-policy.html` and `terms-and-conditions.html`. - **Documentation** - Added `licence.txt` for the PT Root UI font, detailing the SIL Open Font License. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Description
Privacy policy and Terms and Conditions pages fonts are not updated.
Steps To Reproduce
Public Sample App
No response
Environment
Production
Severity
Low (Cosmetic UI issues)
Issue video log
No response
Version
Cloud
The text was updated successfully, but these errors were encountered: