Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Replace usage of TenantRepository.save to TenantService.save in EE #33438

Closed
NilanshBansal opened this issue May 14, 2024 · 1 comment
Closed

[Task]: Replace usage of TenantRepository.save to TenantService.save in EE #33438

NilanshBansal opened this issue May 14, 2024 · 1 comment
Assignees
@NilanshBansal
Labels
Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Issues related to a specific integration Task A simple Todo

Comments

@NilanshBansal
Copy link
Contributor

SubTasks

Description

  • Reduce the reliance on the TenantRepository class, instead rely on the service classes.
  • Using the TenantService class for the save method will call the cache eviction process for the tenant, which will help in maintaining data consistency between redis and the database. (The addition of tenant information to redis is done in this PR).

Clone EE Issue: https://github.com/appsmithorg/appsmith-ee/issues/4173
Note: This issue in CE is only for tracking.
@NilanshBansal NilanshBansal added Task A simple Todo Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. labels May 14, 2024
@NilanshBansal NilanshBansal self-assigned this May 14, 2024
@github-actions github-actions bot added the Integrations Pod Issues related to a specific integration label May 14, 2024
@NilanshBansal
Copy link
Contributor Author

Closing as the EE PR has been merged to release.
https://github.com/appsmithorg/appsmith-ee/pull/4174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NilanshBansal NilanshBansal

Labels
Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Issues related to a specific integration Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NilanshBansal