Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: The text input fields are not getting cleared on Admin settings on clicking Reset button #33450

Closed
1 task done
ankitakinger opened this issue May 14, 2024 · 0 comments · Fixed by #33448
Closed
1 task done

[Bug]: The text input fields are not getting cleared on Admin settings on clicking Reset button #33450

ankitakinger opened this issue May 14, 2024 · 0 comments · Fixed by #33448
Assignees
@ankitakinger
Labels
Admin Settings Issues in admin settings pages Bug Something isn't working Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Team Managers Pod Issues that team managers care about for the security and efficiency of their teams

Comments

@ankitakinger
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

The text input fields are not getting cleared on Admin settings on clicking Reset button, when the last value was a blank string for that text input.

Steps To Reproduce

  1. Go to Admin settings
  2. Alter a text input which is empty
  3. Click on reset button in the bottom bar
  4. Notice that the reset and save button gets disabled but the text input field doesn't go back to empty field

Public Sample App

No response

Environment

Production

Severity

Low (Cosmetic UI issues)

Issue video log

No response

Version

Self Hosted - latest
@ankitakinger ankitakinger added Bug Something isn't working Admin Settings Issues in admin settings pages Needs Triaging Needs attention from maintainers to triage labels May 14, 2024
@ankitakinger ankitakinger self-assigned this May 14, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Low An issue that is neither critical nor breaks a user flow Production labels May 14, 2024
@github-actions github-actions bot added the Team Managers Pod Issues that team managers care about for the security and efficiency of their teams label May 14, 2024
@ankitakinger ankitakinger mentioned this issue May 14, 2024
Merged
2 tasks
ankitakinger added a commit that referenced this issue May 15, 2024
@ankitakinger
chore: Updating embed settings feature tag from Business to Enterprise (
a6b8a36 
#33448)

## Description

- Updating embed settings feature tag from Business to Enterprise
- Also, removing references of "edition" from all over the codebase
- Also, fixing the issue for text input fields not getting cleared on
click of reset button when the old value was a blank string

Fixes [#33450](#33450)
[#33449](#33449)

## Automation

/ok-to-test tags="@tag.Settings, @tag.Fork, @tag.Workspace"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9094357338>
> Commit: 59f05f3
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9094357338&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->
















## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
@appsmith-bot appsmith-bot added the QA Needs QA attention label May 15, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitakinger ankitakinger

Labels
Admin Settings Issues in admin settings pages Bug Something isn't working Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Team Managers Pod Issues that team managers care about for the security and efficiency of their teams
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Updating embed settings feature tag from Business to Enterprise appsmithorg/appsmith
3 participants
@Nikhil-Nandagopal @ankitakinger @appsmith-bot