Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect test coverage from e2e tests #18130

Open
crenshaw-dev opened this issue May 8, 2024 · 2 comments · May be fixed by #18537
Open

Collect test coverage from e2e tests #18130

crenshaw-dev opened this issue May 8, 2024 · 2 comments · May be fixed by #18537
Labels
enhancement New feature or request

Comments

@crenshaw-dev
Copy link
Collaborator

Summary

Today we only collect coverage from unit tests. We should also collect coverage from e2e tests.

Motivation

It would be helpful to get a clearer idea of our complete coverage.

Proposal

New go versions support collecting coverage from running code. We could collect profiles from each of the components and merge them all with the unit coverage data. https://tip.golang.org/doc/go1.20#cover
@crenshaw-dev crenshaw-dev added the enhancement New feature or request label May 8, 2024
@crenshaw-dev
Copy link
Collaborator Author

Looks like combining the outputs of the various tests won't be prohibitively difficult. https://dustinspecker.com/posts/go-combined-unit-integration-code-coverage/

@rumstead rumstead mentioned this issue May 16, 2024
Closed
14 tasks
@rumstead
Copy link
Contributor

rumstead commented May 16, 2024 •
edited

Generating the coverage wasn't too bad, added a draft PR. Now we just need to combine the unit test coverage.out with the e2e coverage and upload it.

EDIT: Any suggestions on how to test this? LOL

@rumstead rumstead linked a pull request Jun 6, 2024 that will close this issue
Draft
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@crenshaw-dev @rumstead