Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Masterminds/sprig to go-sprout/sprout #13059

Open
terrytangyuan opened this issue May 16, 2024 · 1 comment
Open

Switch from Masterminds/sprig to go-sprout/sprout #13059

terrytangyuan opened this issue May 16, 2024 · 1 comment
Labels
type/dependencies PRs and issues specific to updating dependencies type/feature Feature request

Comments

@terrytangyuan
Copy link
Member

Summary

Sprout is an evolved variant of the Masterminds/sprig library, reimagined for modern Go versions. It introduces fresh functionalities and commits to maintaining the library, picking up where Sprig left off. Notably, Sprig had not seen updates for two years and was not compatible beyond Golang 1.13, necessitating the creation of Sprout.

https://github.com/go-sprout/sprout


Message from the maintainers:

Love this feature request? Give it a 👍. We prioritise the proposals with the most 👍.

@terrytangyuan terrytangyuan added the type/feature Feature request label May 16, 2024
@agilgur5
Copy link
Member

It doesn't seem to have added much so far per its PRs and commits, so I think it's too early to do so.

Also per go-sprout/sprout#1 (comment), there will potentially be many breaking changes. Changes to the provided functions, in particular, would be a breaking change to users of Argo too.

There's also a question of if sprig is really needed these days with all the functions in expr: #11608

@agilgur5 agilgur5 added the type/dependencies PRs and issues specific to updating dependencies label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/dependencies PRs and issues specific to updating dependencies type/feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants